Skip to content

Clear stale incremental diagnostics after JSON module changes - #64026

Draft
Jake Bailey (jakebailey) with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-incremental-json-diagnostics
Draft

Clear stale incremental diagnostics after JSON module changes#64026
Jake Bailey (jakebailey) with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-incremental-json-diagnostics

Conversation

Copilot AI commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Incremental builds retained diagnostics from an earlier JSON module shape after the JSON file was fixed.

  • Root cause: JSON modules used an empty declaration emit as their shape signature, so subsequent content changes appeared shape-equivalent.
  • Change: Use the JSON file’s content version as its shape signature, invalidating dependent diagnostics on every content change.
  • Coverage: Add a regression covering valid JSON, removal of a required property, and restoration of that property.

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incremental diagnostics not clearing after JSON file fix Clear stale incremental diagnostics after JSON module changes Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--incremental: diagnostics caused by a JSON module are never cleared after the JSON file is fixed (7.0.2)

2 participants