Python: Fix type hint for Case and Default - #3985
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 3 commits intoMar 13, 2026
Merged
Conversation
Case and DefaultCase and Default
Copilot started reviewing on behalf of
Chinedum Echeta (cecheta)
February 17, 2026 11:12
View session
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the type hints for Case and Default classes in the workflow package to correctly accept SupportsAgentRun instances as targets, resolving issue #3974.
Changes:
- Updated
Case.targetandDefault.targettype hints fromExecutor | strtoExecutor | SupportsAgentRun - Added import for
SupportsAgentRunfrom._agentsmodule - Reformatted
toolstype annotation in_types.pyfrom multi-line to single-line
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/packages/core/agent_framework/_workflows/_edge.py | Fixed type hints for Case and Default target parameter to accept SupportsAgentRun instead of str, and added required import |
| python/packages/core/agent_framework/_types.py | Reformatted tools type annotation from multi-line to single-line |
Chinedum Echeta (cecheta)
force-pushed
the
case-typing
branch
from
February 19, 2026 17:19
fdb66dd to
c9303ec
Compare
Contributor
|
Chinedum Echeta (@cecheta) thank you for your contribution! Could you please also add unit tests for the changes? |
Chinedum Echeta (cecheta)
force-pushed
the
case-typing
branch
from
February 24, 2026 09:56
c9303ec to
9c208b8
Compare
Chinedum Echeta (cecheta)
requested review from
Tao Chen (TaoChenOSU) and
Copilot
February 24, 2026 10:18
Copilot started reviewing on behalf of
Chinedum Echeta (cecheta)
February 24, 2026 10:19
View session
Evan Mattson (moonbox3)
approved these changes
Feb 26, 2026
Evan Mattson (moonbox3)
requested a review
from Eduard van Valkenburg (eavanvalkenburg)
February 26, 2026 08:44
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #3974
Description
CaseandDefaultshould acceptSupportsAgentRunas target, and should not acceptstras it throws an error here.Contribution Checklist