Python: fix: use agent_name for ChatAgent.name in AzureAIAgentClient.as_agent() - #4498
Closed
Qiaochu Hu (hobostay) wants to merge 1 commit into
Closed
Python: fix: use agent_name for ChatAgent.name in AzureAIAgentClient.as_agent()#4498Qiaochu Hu (hobostay) wants to merge 1 commit into
Qiaochu Hu (hobostay) wants to merge 1 commit into
Conversation
Fixes issue where AzureAIClient.as_agent() does not use agent_name for ChatAgent.name when name parameter is not provided. When a user creates an AzureAIChatClient with agent_name parameter, then calls as_agent() without providing a name parameter, the agent_name should be used as the default value for the ChatAgent name. Changes: - Added check in as_agent() method to use self.agent_name when name is None - This ensures the agent_name provided during client initialization is propagated to the ChatAgent name
Mark Wallace (markwallace-microsoft)
added
the
python
github-actions
Bot
changed the title
Member
|
Looks like a duplicate of #4484 |
Contributor
|
Thanks for the contribution but this is a duplicate of the fix made in #4484 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where AzureAIClient.as_agent() does not use agent_name for ChatAgent.name when the name parameter is not provided.
Problem: When a user creates an AzureAIChatClient with agent_name parameter, then calls as_agent() without providing a name parameter, the agent_name should be used as the default value for the ChatAgent name.
Solution: Added a check in the as_agent() method to use self.agent_name when name is None.
File changed: python/packages/azure-ai/agent_framework_azure_ai/_chat_client.py