Python: Add security information to harness features inline docs - #6936
Merged
westey (westey-m) merged 4 commits intoJul 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds inline security guidance across the Python harness feature docs and key samples to help developers reason about trust boundaries when integrating external components (secondary LLMs, remote skill sources, telemetry backends, etc.).
Changes:
- Added “Security Considerations” sections to multiple Python samples (harness, middleware/judge loop, compaction, MCP skills, observability).
- Added security-focused docstrings to core harness-related APIs (skills sources/provider, background agents, judge middleware, summarization, observability settings).
- Normalized a few Microsoft Learn links in the observability sample README (removed
/en-uslocale prefix).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python/samples/02-agents/skills/mcp_based_skill/README.md | Adds MCP skill discovery trust-boundary guidance for external MCP servers. |
| python/samples/02-agents/observability/README.md | Updates docs links and adds telemetry/sensitive-data security guidance. |
| python/samples/02-agents/middleware/README.md | Documents security implications of using a judge client in the loop. |
| python/samples/02-agents/harness/README.md | Summarizes security considerations for multiple opt-in harness capabilities. |
| python/samples/02-agents/compaction/README.md | Highlights summarization as a persistent prompt-injection vector vs other strategies. |
| python/packages/core/agent_framework/observability.py | Adds security considerations to ObservabilitySettings docstring. |
| python/packages/core/agent_framework/_skills.py | Adds security considerations for SkillsProvider, SkillsSource, and MCPSkillsSource. |
| python/packages/core/agent_framework/_harness/_loop.py | Adds security considerations to AgentLoopMiddleware.with_judge docs. |
| python/packages/core/agent_framework/_harness/_background_agents.py | Documents security implications of delegating to background agents. |
| python/packages/core/agent_framework/_harness/_agent.py | Adds security notes for skills_provider and background_agents arguments. |
| python/packages/core/agent_framework/_compaction.py | Adds security notes to SummarizationStrategy docs and constructor args. |
Contributor
Tao Chen (TaoChenOSU)
approved these changes
Jul 6, 2026
Evan Mattson (moonbox3)
approved these changes
Jul 7, 2026
westey (westey-m)
enabled auto-merge
July 7, 2026 09:13
Evan Mattson (moonbox3)
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Description & Review Guide
Related Issue
Fixes #
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.