feat(lock): compute and store input fingerprints during component update - #123
Merged
Daniel McIlvaney (dmcilvaney) merged 2 commits intoApr 28, 2026
Conversation
Wire fingerprint.ComputeIdentity into the update command's save path. After resolving upstream commits, the fingerprint is recomputed from the resolved component config, lock state (ManualBump, UpstreamCommit), and distro release version, then stored as input-fingerprint in the lock file. The fingerprint is recomputed for every resolved component on every update, not just when the upstream commit changes. This ensures config and overlay edits are detected: - Commit changed: Changed=true (as before) - Commit same but fingerprint differs: Changed=true (new) - Both same: skip, no write
Copilot started reviewing on behalf of
Daniel McIlvaney (dmcilvaney)
April 28, 2026 01:22
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR wires fingerprint.ComputeIdentity into azldev component update so that per-component lock files store an input-fingerprint derived from resolved component config, lock state (e.g., manual-bump, upstream-commit), and the distro release-ver. The update flow treats a component as “changed” if either the upstream commit changes or the recomputed fingerprint differs from what’s in the existing lock.
Changes:
- Recompute and persist
input-fingerprintduring lock save, and markChanged=truewhen the fingerprint differs even if the upstream commit is unchanged. - Add helper logic to resolve per-component distro
release-verfor fingerprint computation. - Add/expand tests covering fingerprint write/idempotency and the “fingerprint-only diff implies changed” behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/app/azldev/core/testutils/testenv.go | Adds a ReleaseVer to the test distro version so fingerprints can include releasever in tests. |
| internal/app/azldev/cmds/component/update.go | Computes fingerprints during save, updates “changed” semantics, and resolves release-ver per component. |
| internal/app/azldev/cmds/component/update_test.go | Adds end-to-end-ish update tests with mocked git and lockfile assertions. |
| internal/app/azldev/cmds/component/update_internal_test.go | Adds unit tests for saveComponentLocks fingerprint behavior and lifecycle scenarios. |
Daniel McIlvaney (dmcilvaney)
force-pushed
the
damcilva/add_commit_lock_file_parts/6_fingerprint_integration
branch
from
April 28, 2026 01:36
8736c35 to
5b63146
Compare
| env.FS(), | ||
| *results[idx].config, | ||
| releaseVer, | ||
| fingerprint.IdentityOptions{ |
Contributor
Author
There was a problem hiding this comment.
This is slightly awkward, need to modify the fingerprint library (the values are meant to be opaque as described right now, but this uses them explicitly as a commit). Will fix later.
reuben olinsky (reubeno)
approved these changes
Apr 28, 2026
Daniel McIlvaney (dmcilvaney)
merged commit Apr 28, 2026
9abfdfb
into
microsoft:main
14 checks passed
Daniel McIlvaney (dmcilvaney)
deleted the
damcilva/add_commit_lock_file_parts/6_fingerprint_integration
branch
April 28, 2026 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire fingerprint.ComputeIdentity into the update command's save path. After resolving upstream commits, the fingerprint is recomputed from the resolved component config, lock state (ManualBump, UpstreamCommit), and distro release version, then stored as input-fingerprint in the lock file. In this initial version the fingerprint is recomputed for every resolved component on every update, not just when the upstream commit changes:
Commit changed: Changed=true (as before)
Commit same but fingerprint differs: Changed=true (new)
Both same: skip, no write