Skip to content

fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure#17560

Open
WithEnoughCoffee wants to merge 1 commit into
microsoft:4.0from
WithEnoughCoffee:fix/python-build-br-unresolvable
Open

fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure#17560
WithEnoughCoffee wants to merge 1 commit into
microsoft:4.0from
WithEnoughCoffee:fix/python-build-br-unresolvable

Conversation

@WithEnoughCoffee

@WithEnoughCoffee WithEnoughCoffee commented May 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the pkgconfig(gstreamer-plugins-bad-1.0) BuildRequires from qt6-qtmultimedia. The built RPM was linking against libgstplay/libgstphotography from gstreamer1-plugins-bad-free, which is not shipped in AZL4 — making the package uninstallable and breaking all transitive consumers.

Problem

Koji nightly build of libplasma (task 2590944) fails at buildroot resolution (mock exit 30). The dep chain:

libplasma BR: cmake(KF6Parts)
  → kf6-kparts-devel → kf6-ktextwidgets → qt6-qtspeech
    → qt6-qtmultimedia → libgstplay-1.0.so.0 (not in AZL4)

Fix

Drop the gstreamer-plugins-bad BR and remove the corresponding %files entries for the gstreamer media backend plugin that is no longer built. Base gstreamer plugins and PulseAudio/PipeWire backends remain functional.

Validation

After rebuild of qt6-qtmultimedia, libplasma buildroot resolution succeeds.

Split out of AB#20330.

@WithEnoughCoffee WithEnoughCoffee force-pushed the fix/python-build-br-unresolvable branch from c438370 to efa7560 Compare May 29, 2026 21:47
@WithEnoughCoffee WithEnoughCoffee changed the title python-build: disable tests bcond to fix BR-unresolvable nightly failure fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure May 29, 2026
@WithEnoughCoffee WithEnoughCoffee marked this pull request as ready for review May 29, 2026 22:05
Copilot AI review requested due to automatic review settings May 29, 2026 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables extras and tests build conditionals for the python-build component to avoid dynamically generated test/extra BuildRequires that can be missing from the Koji nightly tag, while retaining a basic %pyproject_check_import sanity check.

Changes:

  • Add build.without = ["extras", "tests"] for python-build via a dedicated component definition file.
  • Re-render python-build spec output to include the generated .azl.macros file and updated rpmautospec release/changelog.
  • Update the python-build lock input fingerprint to match the new component configuration, and remove python-build from the “unmodified inline” component list.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
base/comps/python-build/python-build.comp.toml Adds component build configuration to disable extras/tests bconds with rationale.
base/comps/components.toml Removes python-build from the inline “unmodified” component list since it’s now customized.
locks/python-build.lock Updates input-fingerprint to reflect the new component config inputs.
specs/p/python-build/python-build.spec Rendered spec updated to load generated macros, add Source9999, and bump release/changelog.
specs/p/python-build/python-build.azl.macros Generated macros file defining %_without_extras and %_without_tests.

Comment thread base/comps/python-build/python-build.comp.toml Outdated
Comment thread base/comps/python-build/python-build.comp.toml Outdated
Comment thread base/comps/python-build/python-build.comp.toml Outdated
@WithEnoughCoffee WithEnoughCoffee requested a review from reubeno June 1, 2026 18:23
@WithEnoughCoffee WithEnoughCoffee force-pushed the fix/python-build-br-unresolvable branch from efa7560 to 6d55064 Compare June 1, 2026 18:30
…able nightly failure

The tests bcond (enabled by default when %rhel is undefined) causes
%pyproject_buildrequires -g test to generate dynamic BuildRequires for
test dependencies (filelock, pytest-mock, setuptools_scm, etc.) that
may not be published in the Koji build tag at build time, resulting in
mock exit status 30 (BR-unresolvable).

The extras bcond pulls uv into BuildRequires via
%pyproject_buildrequires -x virtualenv,uv. The uv package currently
fails to build in AZL4, causing cascading BR-unresolvable failures.

Disable both via build.without, aligning with RHEL behavior as the
spec was designed for. The %pyproject_check_import basic sanity check
still runs.

Fixes: Koji task 2593995
Related: AB#20330
@WithEnoughCoffee WithEnoughCoffee force-pushed the fix/python-build-br-unresolvable branch from 6d55064 to bdedfd6 Compare June 8, 2026 19:05
@WithEnoughCoffee WithEnoughCoffee changed the title fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure fix(qt6-qtmultimedia): drop gstreamer-plugins-bad BR to unbreak KDE dep chain Jun 8, 2026
@WithEnoughCoffee WithEnoughCoffee force-pushed the fix/python-build-br-unresolvable branch from bdedfd6 to 7fc5b82 Compare June 8, 2026 19:19
@WithEnoughCoffee WithEnoughCoffee changed the title fix(qt6-qtmultimedia): drop gstreamer-plugins-bad BR to unbreak KDE dep chain fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants