Skip to content

[High] Patch prometheus-adapter for CVE-2026-33186 - #18382

Merged
jslobodzian merged 1 commit into
microsoft:fasttrack/3.0from
Kanishk-Bansal:topic/prometheus-adaptor/CVE-2026-33186
Aug 14, 2026
Merged

[High] Patch prometheus-adapter for CVE-2026-33186#18382
jslobodzian merged 1 commit into
microsoft:fasttrack/3.0from
Kanishk-Bansal:topic/prometheus-adaptor/CVE-2026-33186

Conversation

@akhila-guruju

@akhila-guruju Akhila Guruju (akhila-guruju) commented Aug 11, 2026

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch prometheus-adapter for CVE-2026-33186

Change Log
  • new file: SPECS/prometheus-adapter/CVE-2026-33186.patch
  • modified: SPECS/prometheus-adapter/prometheus-adapter.spec
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Local Build
image

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging fasttrack/3.0 PRs Destined for Azure Linux 3.0 labels Aug 11, 2026
@akhila-guruju

Akhila Guruju (akhila-guruju) commented Aug 11, 2026

Copy link
Copy Markdown
Author

Patch Analysis:
Backported: Yes

Backports upstream grpc/grpc-go@72186f1 to the vendored grpc-go v1.60.1 in prometheus-adapter 0.12.0.

Fix: the server previously accepted requests whose :path omitted the leading / (e.g. Service/Method), which could bypass path-based authorization "deny" rules. With this patch, non-canonical paths are rejected with Unimplemented. An escape hatch (GRPC_GO_EXPERIMENTAL_DISABLE_STRICT_PATH_CHECKING=true) restores the old behavior for compatibility.

Only internal/envconfig/envconfig.go and server.go files are present in azl source code.

Adapted to v1.60.1 API (upstream targets v1.79.3):

  • handleMalformedMethodName() takes t transport.ServerTransport, stream *transport.Stream (no transport.ServerStream in this version).
  • Uses t.WriteStatus(stream, ...) instead of stream.WriteStatus(...).
  • Uses the s.channelzID field instead of s.channelz.

@akhila-guruju Akhila Guruju (akhila-guruju) changed the title Patch prometheus-adapter for CVE-2026-33186 [High] Patch prometheus-adapter for CVE-2026-33186 Aug 11, 2026
@Kanishk-Bansal
Kanishk Bansal (Kanishk-Bansal) marked this pull request as ready for review August 11, 2026 11:18
@akhila-guruju

Copy link
Copy Markdown
Author

Buddy Build has passed and patch applies cleanly.

image

@jslobodzian jslobodzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec review clean (patches referenced + applied, changelog version/release match). PR-check build succeeded with pTests passing on AMD64 and ARM64. Approved.

@jslobodzian
jslobodzian merged commit 3ed9423 into microsoft:fasttrack/3.0 Aug 14, 2026
29 checks passed
@azurelinux-ci-jwt-app

Copy link
Copy Markdown

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1182731&view=results

@azurelinux-ci-jwt-app

Copy link
Copy Markdown

Auto cherry-pick results:

  • 3.0-dev ✅ -> Skipped

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1182731&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fasttrack/3.0 PRs Destined for Azure Linux 3.0 Packaging security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants