Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Changes to support Luis schema v6.0.0#534

Merged
axelsrz merged 15 commits into
masterfrom
axsuarez/luisgen-schema-6.0.0
Mar 6, 2020
Merged

Changes to support Luis schema v6.0.0#534
axelsrz merged 15 commits into
masterfrom
axsuarez/luisgen-schema-6.0.0

Conversation

@axelsrz

@axelsrz axelsrz commented Feb 5, 2020

Copy link
Copy Markdown
Member

fixes #453

@axelsrz axelsrz changed the title initial changes to suppor 6.0.0 Changes to suppor 6.0.0 Feb 11, 2020
@axelsrz axelsrz requested a review from vishwacsena February 11, 2020 20:41
@munozemilio

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@axelsrz axelsrz changed the title Changes to suppor 6.0.0 Changes to support Luis schema v6.0.0 Feb 11, 2020
@chrimc62

Copy link
Copy Markdown

My only feedback is where are the tests?

@chrimc62 chrimc62 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rurounijones

Copy link
Copy Markdown

Ahoi all. This has been sitting in limbo for nearly 3 weeks. Is there an ETA / priority for this?

@axelsrz axelsrz marked this pull request as ready for review March 4, 2020 04:27
@munozemilio

munozemilio commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

Build is fixed but I think some tests are missing

@munozemilio munozemilio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

@axelsrz axelsrz dismissed munozemilio’s stale review March 6, 2020 07:58

Changes addressed

@axelsrz axelsrz merged commit 2c061ae into master Mar 6, 2020
@axelsrz axelsrz deleted the axsuarez/luisgen-schema-6.0.0 branch March 6, 2020 07:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LUISgen generates bad C# files from JSON app file

4 participants