Skip to content

Move DurableTaskRegistry to Abstractions#76

Merged
jviau merged 3 commits into
microsoft:mainfrom
jviau:move-registry
Nov 10, 2022
Merged

Move DurableTaskRegistry to Abstractions#76
jviau merged 3 commits into
microsoft:mainfrom
jviau:move-registry

Conversation

@jviau

@jviau jviau commented Nov 10, 2022

Copy link
Copy Markdown
Member

Overview

This PR moves DurableTaskRegistry to Abstractions assembly. The reason for this move is for the code-gen scenario. It is important to have access to the registry from just the abstractions package, so registration methods can be generated.

Summary of Changes

  • DurableTaskRegistry moved to Abstractions assembly.
  • DurableTaskRegistry.Build moved to an extension method BuildFactory in worker assembly.
  • Internal dictionaries on the registry were changed to IDictionary.
  • Systems.Collection.Immutable removed from Abstractions.
    • Systems.Collection.Immutable was added to Worker.Grpc, but that is already used by another nuget package. This addition is to resolve a version mismatch.
  • System.Collections.Concurrent removed - it was unused.
  • Abstractions internals were made visible to Worker and Client projects.
    • Not the gRPC implementations, so we do not accidentally depend on functionality other worker implementations would not have access to.
    • Had to adjust some shared sections to avoid type duplication.

@jviau jviau requested a review from cgillum November 10, 2022 01:01

@cgillum cgillum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM!

Comment thread src/Abstractions/DurableTaskRegistry.cs Outdated
Comment thread src/Abstractions/DurableTaskRegistry.cs
@jviau jviau merged commit 4d12d5a into microsoft:main Nov 10, 2022
@jviau jviau deleted the move-registry branch November 10, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants