Scalar Diagnose Issue 2.38.1.vfs.0.0

[aaronberger-msft]

• I was not able to find an open
  or closed issue matching
  what I'm seeing, including in the git-for-windows/git tracker.

Setup

• Which version of microsoft/git are you using? Is it 32-bit or 64-bit?

$ git --version --build-options

git version 2.38.1.vfs.0.0
cpu: x86_64
built from commit: 0de34d54680002380b4e1adad74db64a34e03053
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon

Are you using Scalar or VFS for Git?

scalar

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver

Microsoft Windows [Version 10.0.22623.875]

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

CMD

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

scalar diagnose

• What did you expect to occur after running these commands?
  Creation of a diagnose zip file
• What actually happened instead?

Error-out about lack of perms. An empty .zip file is actually created at the path. I have reproed this on 5+ user's machines and all have errored in the same way. Trying to run from different directories, mucking with permission manually and from elevated and non-elevated cmd prompts all seem to produce a similar error:

Available space on 'E:/': 115.27 GiB
error: could not read 'E:\.scalarCache/id_ba47400f-eebe-4850-a8bf-ef694ef81414/info': Permission denied
fatal: unable to create diagnostics archive E:/ON16G/src/.scalarDiagnostics/git-diagnostics-20221027_101015.zip: Permission denied
Collecting diagnostic info

I am only able to repro this on a clone of Office Monorepo. I did a fresh clone of a normal repo (no gvfs config or sparse) and a fresh clone of the Office Monorepo (to eliminate potential perm issues arising from environment most office devs work from) in the same containing directory. I was able to run scalar diagnose in the normal repo successfully but not in the Office Repo. I don't know if that means this only manifests in sparse checkouts only or if there is something in the gvfs config for OMR that the most recent version dislikes. Regardless, nothing has changed in respect to the config for Office Monorepo sparse settings recently and older versions of microsoft/git are still able to run scalar diagnose properly.

• If the problem was occurring with a specific repository, can you specify
  the repository?

  • Public repo: insert URL here
  • Windows monorepo
  • Office monorepo
  • Other Microsoft-internal repo: insert name here
  • Other internal repo.

[derrickstolee]

@aaronbergerM Thanks for the detailed report.

You say that old clones don't work, but new clones do work. Could you do the following in each type of repo and let us know if there are any interesting differences:

1. git config gvfs.sharedCache
2. cat .git/objects/info/alternates

Thanks!

[aaronberger-msft]

@aaronbergerM Thanks for the detailed report.

You say that old clones don't work, but new clones do work. Could you do the following in each type of repo and let us know if there are any interesting differences:

1. git config gvfs.sharedCache
2. cat .git/objects/info/alternates

Thanks!

Sorry I should be more clear. The old and new clones both break with the specified version of microsoft/git.

With older versions of microsoft/git (2.37.1 is most recent I've validated as working), scalar diagnose works on old and the new clone.

The current 2.38.1 version doesn't work on the new clone or the old clone of office. It does run successfully on a random non scalar/gvfs repo that I also cloned just looking for a repro outside of Office monorepo.

New and old clones of office are both pointing to the same scalar cache directory

[derrickstolee]

@aaronbergerM this bug should be fixed in the v2.38.1.vfs.0.1 pre-release. Anyone having trouble with scalar diagnose should install that version from the releases page.

For now, we will keep this as a pre-release to avoid pinging all users for an upgrade.