fixup! gvfs-helper: run prefetch index-pack in parallel#941
Open
derrickstolee wants to merge 1 commit into
Open
fixup! gvfs-helper: run prefetch index-pack in parallel#941derrickstolee wants to merge 1 commit into
derrickstolee wants to merge 1 commit into
Conversation
Signed-off-by: Derrick Stolee <stolee@gmail.com>
Author
|
@dscho hopefully this is easy to cherry-pick into your rebase onto 2.54.0[.rc*] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding the
gvfs.prefetchThreadsconfig option in #876, I didn't realize that the childgit index-packprocesses would output the hashes of the pack contents.This makes the output quiet. It's committed as a
fixup!so it can be squashed in thevfs-2.55.0release (or this PR can be repeated on that branch and squashed in 2.56.0).The tests check stderr because the parallel process runner sets
stdout_to_stderrso the previous behavior showed up overstderrfrom the top level process.GVFS Protocol.