-
Notifications
You must be signed in to change notification settings - Fork 85
feat(open): add 'open vscode' and 'open ssms', remove retired 'open ads' #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dlevy-msft-sql
wants to merge
37
commits into
microsoft:main
Choose a base branch
from
dlevy-msft-sql:pr-685
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
1f6f5b3
feat(open): add sqlcmd open vscode and sqlcmd open ssms commands
dlevy-msft-sql 33795b4
fix: handle JSONC in VS Code settings.json and use atomic write
dlevy-msft-sql a0b4f9d
fix: prevent TestVSCode from writing to real settings.json
dlevy-msft-sql 27456da
fix: suppress errcheck lint for best-effort os.Remove on cleanup paths
dlevy-msft-sql 3d9db6b
fix: RunWithOutput stdout conflict and clipboard security warning
dlevy-msft-sql 0f24d13
i18n: localize Linux clipboard fallback error
dlevy-msft-sql c3725f2
feat: remove sqlcmd open ads (Azure Data Studio retired)
dlevy-msft-sql 6beabc9
feat(open): launch SSMS via ssms:// URL handler with registry-based d…
dlevy-msft-sql 6e83c64
revert: launch SSMS via ssms:// URL handler
dlevy-msft-sql 32d2200
feat(open): discover SSMS via vswhere and add --version flag
dlevy-msft-sql 264d888
feat(open): add --build flag and build-aware VS Code discovery
dlevy-msft-sql 639da60
fix(tools): include exe name as argv[0] on Windows so first flag is n…
dlevy-msft-sql 87bfee0
fix(tools): launch tools detached so sqlcmd returns immediately
dlevy-msft-sql b7b2357
fix(open): connect via mssql --open-url instead of opening empty window
dlevy-msft-sql ad23b30
fix(tools): redirect gui child stdio to null device so sqlcmd exits
dlevy-msft-sql e8ad757
feat(open): finalize vscode launch for mssql extension
dlevy-msft-sql b516248
fix(open): satisfy golangci-lint (errcheck, QF1007)
dlevy-msft-sql f9c9012
fix(open): return empty string when container inspect fails
dlevy-msft-sql 89bafde
fix(open): use Mandatory encrypt enum and honor VSCODE_EXTENSIONS
dlevy-msft-sql 89150a0
refactor(open): drop ai-slop comments and tautological clipboard tests
dlevy-msft-sql b88feeb
fix(tools): launch macOS vscode via in-bundle binary not the .app dir…
dlevy-msft-sql 3b237e3
fix(open): pass ssms username argv raw without bogus shell-escape
dlevy-msft-sql e68d8cf
fix(open): back up settings.json when vscode comments would be lost
dlevy-msft-sql 42acd04
refactor(open): drop dead vscode RunWithOutput and tautological tests
dlevy-msft-sql f83ddd0
revert: keep macOS vscode searchLocations on the .app bundle
dlevy-msft-sql 5fd497d
fix(open): don't claim mssql extension install succeeded when we only…
dlevy-msft-sql bf37b55
fix(tools): detach stdio when /dev/null open fails to avoid pipe-drai…
dlevy-msft-sql b89b51f
test(open): assert full settings.json path tail per OS not just Code
dlevy-msft-sql 98bf667
refactor(open): drop --install-extension; vscode:// URL already prompts
dlevy-msft-sql 24a3a29
docs: address PR feedback on open vscode/ssms
dlevy-msft-sql 406fc0b
refactor(tools): drop unused RunWithOutput and stale --install-extens…
dlevy-msft-sql f72ee89
fix(i18n): restore translation catalog after rebase
dlevy-msft-sql f3c6199
fix(open): drop tcp: prefix and base64-encode test password
dlevy-msft-sql 0d117d3
feat(open): platform-conditional vscode/ssms hints in help
dlevy-msft-sql 85a8635
test(ssms): cover partial-install case; drop trivial Name() test
dlevy-msft-sql 30facd1
refactor(open): preserve vscode settings.json comments via hujson
dlevy-msft-sql d7151bc
feat(open): enable 'sqlcmd open' on linux
dlevy-msft-sql File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.