Enhancement: add osversion.Build() utility - #569
Merged
John Howard (lowenna) merged 1 commit intoApr 19, 2019
Conversation
|
|
||
| // Build gets the build-number on Windows | ||
| // The calling application must be manifested to get the correct version information. | ||
| func Build() uint16 { |
Contributor
Author
There was a problem hiding this comment.
FWIW; I was in doubt wether to name this Build() or BuildNumber()
Contributor
There was a problem hiding this comment.
Contributor
|
Sebastiaan van Stijn (@thaJeztah) Needs a rebase |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn (thaJeztah)
force-pushed
the
add_build_function
branch
from
April 17, 2019 22:30
b4714cb to
92cb5b6
Compare
Contributor
Author
|
rebased 👍 |
Sebastiaan van Stijn (thaJeztah)
added a commit
to thaJeztah/cli
that referenced
this pull request
Oct 26, 2019
full diff: microsoft/hcsshim@672e52e...2226e08 - microsoft/hcsshim#569 Enhancement: add osversion.Build() utility - relates to moby/moby#39100 Use Microsoft/hcsshim constants and deprecate pkg/system.GetOsVersion() Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
3 tasks
Jenkins (docker-jenkins)
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Oct 28, 2019
full diff: microsoft/hcsshim@672e52e...2226e08 - microsoft/hcsshim#569 Enhancement: add osversion.Build() utility - relates to moby/moby#39100 Use Microsoft/hcsshim constants and deprecate pkg/system.GetOsVersion() Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 5e4c7eba448246e90f88c0d319a45a62b2e62c33 Component: cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jhowardmsft ptal