Fix Numeric strings being converted to Datetime objects

[Shem Ogumbe (shemogumbe)]

Fixes microsoftgraph/msgraph-sdk-python#653

Overview

The PR fixes a problem where pendulum assumes all 4-digit numeric strings are Datetimes, e. 1212, 1214, 2530, 9057

Fixes # microsoftgraph/msgraph-sdk-python#653

Demo

The Script below,

async def get_my_messages():
    try:

        result = await user_client.sites.by_site_id(
            "yygbp.sharepoint.com,ab839da2-a22d-4e5c-bbeb-5060fad36e50,5cfc6d41-e5f6-4341-93fb-98728649efde"
        ).lists.by_list_id('6c8b411a-e440-4b24-9ee3-bfd3f06a9b4e'
                           ).items.by_list_item_id('1').get()
        print(f"sharepont list item id {result.id}")
        print(f"sharepoint list item fields {result.fields}")
        print(
            f"sharepoint list item text field {result.fields.additional_data['Doc_id']}"
        )

Output before

sharepoint list item fields FieldValueSet(additional_data={'@odata.etag': '"0f11e7ca-3f0e-46ce-b7e7-f2dfffe373da,2"', 'Title': 'Composition', 'LinkTitle': 'Composition', 'Doc_id': DateTime(1212, 1, 1, 0, 0, 0, tzinfo=Timezone('UTC')), 'Doc_numner': 1212.0, 'ContentType': 'Item', 'Modified': DateTime(2024, 8, 23, 14, 54, 17, tzinfo=Timezone('UTC')), 'Created': DateTime(2024, 8, 23, 14, 54, 17, tzinfo=Timezone('UTC')), 'AuthorLookupId': '9', 'EditorLookupId': '9', '_UIVersionString': '2.0', 'Attachments': True, 'Edit': '', 'LinkTitleNoMenu': 'Composition', 'ItemChildCount': '0', 'FolderChildCount': '0', '_ComplianceFlags': '', '_ComplianceTag': '', '_ComplianceTagWrittenTime': '', '_ComplianceTagUserId': ''}, id='1', odata_type=None)
sharepoint list item text field 1212-01-01 00:00:00+00:00

Output After

sharepoint list item fields FieldValueSet(additional_data={'@odata.etag': '"0f11e7ca-3f0e-46ce-b7e7-f2dfffe373da,2"', 'Title': 'Composition', 'LinkTitle': 'Composition', 'Doc_id': '1212', 'Doc_numner': 1212.0, 'ContentType': 'Item', 'Modified': DateTime(2024, 8, 23, 14, 54, 17, tzinfo=Timezone('UTC')), 'Created': DateTime(2024, 8, 23, 14, 54, 17, tzinfo=Timezone('UTC')), 'AuthorLookupId': '9', 'EditorLookupId': '9', '_UIVersionString': '2.0', 'Attachments': True, 'Edit': '', 'LinkTitleNoMenu': 'Composition', 'ItemChildCount': '0', 'FolderChildCount': '0', '_ComplianceFlags': '', '_ComplianceTag': '', '_ComplianceTagWrittenTime': '', '_ComplianceTagUserId': ''}, id='1', odata_type=None)
sharepoint list item text field 1212

Notes

This change could be reverted if pendulum does an update that fixes the bug.

Testing Instructions

[Vincent Biret (baywet)]

Thanks for the contribution!
Also:

• unit tests
• changelog
• version bump
• replicate in other serialization libraries

[Vincent Biret (baywet)]

just making sure this method is not accessible from outside of the class?

[Shem Ogumbe (shemogumbe)]

It's an instance method, and we really just need it here in the entire project, so nope, not accessible outside the class

[Vincent Biret (baywet)]

shouldn't it start with __ ?

[Vincent Biret (baywet)]

Thank you for making the changes!

[Shem Ogumbe (shemogumbe)]

Thanks for the contribution! Also:

• unit tests
• changelog
• version bump
• replicate in other serialization libraries

Added Unit tests, changelog and version bump

The other serialization libraries do not use pendulum thus do not have the problem

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud