fix(osx): implement introspect.reinit_lock to avoid fork() crash#1315
Merged
Conversation
The macOS malloc zone advertises version >= 9, for which libmalloc invokes introspect->reinit_lock from the atfork_child handler (_malloc_fork_child) without a NULL check. The introspection struct left reinit_lock unset (NULL), so any fork() in a process that statically links the mimalloc zone made the child jump to address 0 and crash (EXC_BAD_ACCESS at 0x0) on macOS 15. Provide a no-op reinit_lock: mimalloc has no zone-level locks to reinitialize after fork.
Author
|
@microsoft-github-policy-service agree company="Tencent" |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submission of #1311 against
devas requested by @daanx.Same commit, identical diff. Closing #1311.
cc @daanx
The macOS malloc zone advertises version >= 9, for which libmalloc invokes
introspect->reinit_lockfrom the atfork_child handler (_malloc_fork_child)without a NULL check. The introspection struct left
reinit_lockunset (NULL),so any
fork()in a process that statically links the mimalloc zone made thechild jump to address 0 and crash (EXC_BAD_ACCESS at 0x0) on macOS 15.
Provide a no-op
reinit_lock: mimalloc has no zone-level locks to reinitializeafter fork.