Fix strict function prototype warnings#467
Merged
Merged
Conversation
Fix warning ``warning: function declaration isn’t a prototype`` when building mimalloc with ``-Wstrict-prototypes`` flag. In C argumentless functions should be declared as ``func(void)``. Reproducer: ```shell $ cmake ../.. -DCMAKE_C_FLAGS="-Wstrict-prototypes" $ make VERBOSE=1 ``` Co-authored-by: Sam Gross <colesbury@gmail.com> Co-authored-by: Neil Schemenauer <nas@arctrix.com> Signed-off-by: Christian Heimes <christian@python.org>
|
|
Contributor
Author
|
We are testing mimalloc for CPython. Python core is compiled with |
Collaborator
|
Thanks so much! I didn't know about the strict-prototypes flag -- I'll add it to the cmake also as that is much better. I am excited to see the work on evaluating mimalloc for CPython -- let's make it great for that environment as well :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix warning
warning: function declaration isn’t a prototypewhenbuilding mimalloc with
-Wstrict-prototypesflag. In C argumentlessfunctions should be declared as
func(void).Reproducer:
$ cmake ../.. -DCMAKE_C_FLAGS="-Wstrict-prototypes" $ make VERBOSE=1Co-authored-by: Sam Gross colesbury@gmail.com
Co-authored-by: Neil Schemenauer nas@arctrix.com
Signed-off-by: Christian Heimes christian@python.org