Define _DEFAULT_SOURCE for syscall and realpath#468
Merged
Conversation
Define ``_DEFAULT_SOURCE`` in ``random.c`` and ``alloc.c``. The macro is required for ``syscall()`` and ``realpath()``. Other files like ``os.c`` already define the macro. Signed-off-by: Christian Heimes <christian@python.org>
Contributor
Author
|
The changes are required to vendor latest mimalloc with CPython. Without the changes I'm getting |
Collaborator
|
Thanks! I may move the definitions to mimalloc-internal.h instead later on. (Currently reading up about _DEFAULT_SOURCE and if it the right thing to do or not). |
Contributor
Author
|
You are welcome! The man pages for syscall and realpath lists the required macros to enable features: and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
_DEFAULT_SOURCEinrandom.candalloc.c. The macrois required for
syscall()andrealpath(). Other files likeos.calready define the macro.Signed-off-by: Christian Heimes christian@python.org