Rename _os_random_weak to _mi_os_random_weak#474
Merged
Conversation
The ``_os_random_weak`` function is the only non-static function besides ``_ZSt15get_new_handlerv`` that is not prefixed with ``mi`` or ``_mi``. The discrepancy was discovered by CPython's smelly script. The checker looks for exported symbols that don't have well-defined prefixes. Signed-off-by: Christian Heimes <christian@python.org>
Collaborator
|
Thanks Christian! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_os_random_weakfunction is the only non-static functionbesides
_ZSt15get_new_handlervthat is not prefixed withmior_mi.The discrepancy was discovered by CPython's smelly script. The checker
looks for exported symbols that don't have well-defined prefixes.
Signed-off-by: Christian Heimes christian@python.org