Fix publish and release pipelines#478
Open
vmoroz wants to merge 2 commits into
Open
Conversation
jasongin
requested changes
May 27, 2026
| script: | | ||
| Rename-Item ` | ||
| -Path "$(Build.SourcesDirectory)/out/bin/Release/NodeApi/aot/win-x64/publish/Microsoft.JavaScript.NodeApi.node" ` | ||
| -NewName "Microsoft.JavaScript.NodeApi.dll" |
Member
There was a problem hiding this comment.
There is already another file named Microsoft.JavaScript.NodeApi.dll in this directory - it is the managed assembly DLL that the unmanaged .node file loads after boostrapping .NET. So it looks like this rename will overwrite that file and the final build output will not be correct.
Member
Author
There was a problem hiding this comment.
Good catch! I will fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix publish and release pipelines
Two unrelated breakages were blocking releases.
publish.yml — ESRP rejects
.nodefilesMicrosoft.JavaScript.NodeApi.nodeis a native module — a PE/COFF DLLwith a non-
.dllextension. ESRP's PendingAnalysis stage cannot handlethat extension and fails after a 30-minute hang.
Fix: rename
.node→.dllbefore ESRP, sign through the existing**/Microsoft.JavaScript.NodeApi.dllglob, rename back after.Also bumped
EsrpCodeSigning@5→@6(two call sites).release.yml — PAT-based service connections no longer permitted
The
Nuget - ms/react-native-publicandNpm - ms/react-nativeserviceconnections authenticate via PAT, which policy now forbids. Managed
Identity is mandatory.
Fix: before each publish, an
AzureCLI@2step fetches an AAD tokenfor the AzDO resource (
499b84ac-1321-427f-aa17-267ca6975798) under MIand overrides the service connection's auth at runtime via
##vso[task.setendpoint id=<guid>;field=authParameter;key=apitoken].1ES.PublishNuGet@1andnpmAuthenticate@0then run unchanged andtransparently use the MI-derived token.
Notes:
service connections, so the connection itself still has to be
configured with a PAT. The override-at-runtime pattern is the only
way to actually publish under MI today; the stored PAT is bypassed
on every build. This is the long-term shape unless ADO changes.
Office-Hermes-Windows-Botis usedbecause the official
Office-Node-Api-DotNet-BotMI does not yethave the right permissions on these feeds. Switch back once it does.
Drive-by
release.yml: renamedCustomPipelineTemplates→OfficePipelineTemplatesand dropped theES365AIMigrationTooling-BulkMigrated-Releaselegacy build tag.Test runs