fix: close kqueue fd in SetupExitCallback on macOS#931
Open
codebytere-ant wants to merge 1 commit into
Open
Conversation
SetupExitCallback opens a kqueue() per spawned pty to wait on NOTE_EXIT, but never closes it before the watcher thread returns, leaking one kqueue fd per pty.spawn() for the host process lifetime. The Chromium kill_mac.cc this is based on closes the kqueue via ScopedFD; the equivalent here is an explicit close(kq) once the kevent wait completes.
Author
|
@microsoft-github-policy-service agree company="Anthropic" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS,
SetupExitCallbackopens akqueue()per spawned pty to wait onNOTE_EXIT, but never closes it before the watcher thread returns. This leaks one kqueue file descriptor perpty.spawn()for the lifetime of the host process.Repro:
The Chromium reference this code is based on (kill_mac.cc) closes the kqueue via
ScopedFD; the equivalent here is an explicitclose(kq)once the kevent wait completes.close(-1)is a harmless EBADF ifkqueue()itself failed, so no guard is needed.Adds a regression test alongside the ptmx leak test from #882.
cc @deepak1556