This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Fixes typing error identified by a new mypy release#129
Merged
Conversation
Contributor
Author
|
The new feature to typeshed was introduced in this PR: python/typeshed#4155 |
ranweiler
reviewed
Oct 9, 2020
ranweiler
reviewed
Oct 9, 2020
ranweiler
approved these changes
Oct 9, 2020
ranweiler
reviewed
Oct 9, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a build failure from a typing issue where we were sorting an Optional[Datetime], which is not directly sortable.
This was discovered during an update to mypy, which included a new typeshed that supports checks if list.sort arguments are sortable.