feat(driver): bundle playwright-core in driver, keep only Node.js in driver-bundle#1936
Open
yury-s wants to merge 3 commits into
Open
feat(driver): bundle playwright-core in driver, keep only Node.js in driver-bundle#1936yury-s wants to merge 3 commits into
yury-s wants to merge 3 commits into
Conversation
…driver-bundle Move the platform-independent playwright-core package and the DriverJar loader from driver-bundle into the always-present driver module. driver-bundle now contains only the Node.js binaries, one per platform. DriverJar assembles the driver directory from two classpath roots: the shared package (driver module) and the host platform's Node.js (driver-bundle), the latter skipped when a preinstalled Node.js is configured. This lets a user with a preinstalled Node.js (PLAYWRIGHT_NODEJS_PATH) exclude the driver-bundle dependency entirely.
dgozman
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright-corepackage and theDriverJarloader fromdriver-bundleinto the always-presentdrivermodule.driver-bundlenow contains only the Node.js binaries (one per platform).PLAYWRIGHT_NODEJS_PATH) can now excludedriver-bundleentirely;DriverJarextracts the package from thedriverjar and uses the preinstalled node. Ifdriver-bundleis absent and no node is configured, it fails with an actionable error.Verified
driver.jarcarriesDriverJar+driver/package/,driver-bundle.jarcarries only the 5 Node.js binaries.TestInstall(moved to theplaywrightmodule) passes, including both preinstalled-node paths.driver-bundleremoved from the classpath:Playwright.create()succeeds whenPLAYWRIGHT_NODEJS_PATHis set, and fails with a clear message when it is not.References #1196
References #467