feat(clock): add java.time.Instant overloads to the Clock API#1937
Closed
yury-s wants to merge 1 commit into
Closed
feat(clock): add java.time.Instant overloads to the Clock API#1937yury-s wants to merge 1 commit into
yury-s wants to merge 1 commit into
Conversation
Add Instant overloads to Clock.pauseAt/setFixedTime/setSystemTime and InstallOptions.setTime alongside the existing java.util.Date ones. The API generator synthesizes an Instant overload for Date-typed unions (Clock only); the Date/Instant impls delegate to the canonical millis-based overload. References microsoft#1686
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft / exploration for #1686.
Summary
java.time.Instantoverloads toClock.pauseAt/setFixedTime/setSystemTimeandClock.InstallOptions.setTime, alongside the existingjava.util.Dateones.Instantoverload forDate-typed unions (which occur only inClock);ClockImpl'sDate/Instantoverloads delegate to the canonical millis-basedlongoverload.Design note
The issue asks for
LocalDateTime, but a system/fixed time is an absolute instant andLocalDateTimehas no zone — converting it would force a silentsystemDefault()guess. So this exposesInstant(the unambiguous match) instead; callers holding aLocalDateTimeconvert explicitly, e.g.localDateTime.toInstant(ZoneOffset.UTC)(the added test demonstrates this).References #1686