feat(docker): pre-extract the driver in images to avoid /tmp unpacking#1938
Open
yury-s wants to merge 1 commit into
Open
feat(docker): pre-extract the driver in images to avoid /tmp unpacking#1938yury-s wants to merge 1 commit into
yury-s wants to merge 1 commit into
Conversation
Add a CLI `install-driver` command that extracts the driver (the playwright-core package and the host Node.js binary) into a fixed directory, and a PLAYWRIGHT_DRIVER_DIR environment variable that points Playwright at a preinstalled driver directory (PreinstalledDriver, no extraction). The official Docker images now extract the driver once at build time and select it at runtime, so the library no longer unpacks executables into /tmp on every launch. Fixes: microsoft#1268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright-corepackage into/tmpon everyPlaywright.create()— addressing the immutable-infra concern in [Feature] Java library poor playwright/java docker image integration #1268.CLI install-driver [dir]command extracts the driver (theplaywright-corepackage + the host Node.js binary) into a fixed directory.PLAYWRIGHT_DRIVER_DIRenvironment variable (env equivalent of theplaywright.cli.dirsystem property) points Playwright at a preinstalled driver directory viaPreinstalledDriver— zero extraction.install-driverat build into/ms-playwright-driverand bakePLAYWRIGHT_DRIVER_DIRfor runtime.Notes
install-driverproduces a self-containedpackage/cli.js+node; withPLAYWRIGHT_DRIVER_DIRset,driverDiris that path (no/tmp) and Chromium launches.TestInstallcovers the extract-and-reuse flow.docker buildhere; the Java side is verified end-to-end and the Dockerfile edits mirror the existinginstallsteps.Fixes #1268