fix(transport): handle connection error correctly (#650)#651
Merged
Conversation
|
|
Contributor
|
A test for ws connection timeout for sync and async would be awesome. |
Contributor
Author
ok |
x0day
commented
Apr 26, 2021
Contributor
Author
|
add the test test_connect_to_closed_server_without_hangs, please check. |
kumaraditya303
suggested changes
Apr 27, 2021
kumaraditya303
approved these changes
Apr 27, 2021
mxschmitt
reviewed
Apr 27, 2021
mxschmitt
left a comment
mxschmitt
left a comment
Contributor
There was a problem hiding this comment.
Looks good but the currently handling of having run and start is confusing I think from my perspective. Will take a more detailed look later how to avoid that.
Contributor
Author
yep maybe we can fix hang error at this time and think about allow |
pavelfeldman
added a commit
to pavelfeldman/playwright-python
that referenced
this pull request
May 7, 2021
) (microsoft#651)" This reverts commit 82885a1. Sorry about the revert. I don't think this handles the connection timeout properly, so let me see if we can get a better fix here.
pavelfeldman
added a commit
that referenced
this pull request
May 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#650