Remove cv2 stubs now that they're generated - #292
Merged
Conversation
Avasam
marked this pull request as ready for review
August 6, 2023 17:09
Contributor
Author
|
@debonte opencv-python 4.8.0.76 has been released with all the necessary fixes. This can be merged. Any further issue with OpenCV should be forwarded to https://github.com/opencv/opencv |
Contributor
|
Thanks @Avasam! |
debonte
approved these changes
Aug 12, 2023
daniel-zullo-frequenz
pushed a commit
to daniel-zullo-frequenz/python-type-stubs
that referenced
this pull request
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCV 4.8 has been released with Python type stubs generation, and opencv-python 4.8.0.74 has released wheels including them.
I think at least the following two issues should be resolved before merging this:
cv2.typingmodule is missing from generated wheels opencv/opencv-python#869cv2.erroris missing properties opencv/opencv#23925And optionally:
cv2.mat_wrapper.Mator derived type results in partially unknownndarrayopencv/opencv#23780I'm still opening this PR early in preparation, to tag closable issues, and to let you know that these upstream issues should be resolved before removing this stub.
Closes #176, Closes #202, Closes #213, Closes #279