Skip to content

CMake Header-Only Target#46

Merged
mjp41 merged 4 commits into
masterfrom
cmake
May 9, 2019
Merged

CMake Header-Only Target#46
mjp41 merged 4 commits into
masterfrom
cmake

Conversation

@mjp41

@mjp41 mjp41 commented May 9, 2019

Copy link
Copy Markdown
Member

This PR creates a header only CMake target, which can be included by other projects without adding all the tests targets.

mjp41 added 2 commits May 8, 2019 20:55
Use the CMake INTERFACE target type to include the build settings for
snmalloc in other projects using headers only.
@mjp41 mjp41 requested review from davidchisnall and sylvanc May 9, 2019 09:24
@mjp41

mjp41 commented May 9, 2019

Copy link
Copy Markdown
Member Author

@nwf I am afraid this will conflict with your PR, but is easy to resolve. Sorry.

@nwf

nwf commented May 9, 2019

Copy link
Copy Markdown
Contributor

@mjp41 No worries; thanks for the heads up.

davidchisnall
davidchisnall previously approved these changes May 9, 2019

@davidchisnall davidchisnall left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants