Add trim and NativeAOT safety attributes#1471
Merged
Merged
Conversation
eerhardt
reviewed
Jun 19, 2025
AArnott
force-pushed
the
dev/andarno/nativeAOT
branch
from
9e8ac72 to
cc30086
Compare
Closed
AArnott
force-pushed
the
dev/andarno/nativeAOT
branch
from
cc30086 to
df9d517
Compare
eerhardt
reviewed
Jun 19, 2025
eerhardt
approved these changes
Jun 19, 2025
eerhardt
left a comment
eerhardt
left a comment
Member
There was a problem hiding this comment.
LGTM. Just one comment left.
This gets vs-threading to self-identify as a NativeAOT-ready assembly, and adds the attributes on the specific methods that are *not* safe. Incidentally, all the trim-unsafe methods are strictly for runtime diagnostics rather than critical functionality.
AArnott
force-pushed
the
dev/andarno/nativeAOT
branch
from
0261f2d to
5cb439e
Compare
lifengl
approved these changes
Jun 20, 2025
This was referenced Jun 22, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets vs-threading to self-identify as a NativeAOT-ready assembly, and adds the attributes on the specific methods that are not safe. Incidentally, all the trim-unsafe methods are strictly for runtime diagnostics rather than critical functionality.