Validate Yarn lockfile selectors - #14663
Merged
Sean McManus (sean-mcmanus) merged 2 commits intoAug 11, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 11, 2026 01:23
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a small Node-based validator to ensure dependency/resolution selectors declared in Extension/package.json are actually present as selectors in Extension/yarn.lock, and wires it into CI to catch stale selectors that Yarn Classic may not fail on during --frozen-lockfile.
Changes:
- Add
verify-yarn-lockvalidator andtest-yarn-lockfixture tests underExtension/.scripts/. - Add corresponding npm scripts to run the validator and its tests.
- Run the validator + tests in the shared compile-and-test workflow before dependency installation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Extension/package.json | Adds test-yarn-lock / verify-yarn-lock scripts to run new validator and its tests. |
| Extension/.scripts/verifyYarnLock.mjs | Implements selector extraction from yarn.lock and comparison against expected selectors from package.json. |
| Extension/.scripts/verifyYarnLock.test.mjs | Adds focused fixture tests covering stale selectors and common selector forms (scoped/nested). |
| .github/workflows/job-compile-and-test.yml | Runs new validation step before yarn install in CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sean McManus (sean-mcmanus)
marked this pull request as ready for review
August 11, 2026 01:31
Bob Brown (bobbrow)
approved these changes
Aug 11, 2026
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 11, 2026 18:35
View session
Sean McManus (sean-mcmanus)
deleted the
seanmcm/devbox2-wsl/agent3/validate-yarn-lock-selectors
branch
August 11, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add static, pre-install validation that checks dependency and resolution selectors from
Extension/package.jsonare represented inExtension/yarn.lock. Run focused fixture tests and current-manifest validation before dependency installation in the shared compile-and-test workflow, catching stale resolution selectors that Yarn Classic's--frozen-lockfileaccepts.Testing
yarn test-yarn-lockyarn verify-yarn-lockyarn eslint --report-unused-disable-directives src test ui .scriptsfast-uri@^3.1.5for the historical malformed state from 7777353git diff --check origin/main...HEAD