Lock localization literals - #14664
Merged
Sean McManus (sean-mcmanus) merged 1 commit intoAug 11, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 11, 2026 01:39
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates localization metadata so technical literals (e.g., #include, configuration/setting names, boolean literals, and option prefixes) are preserved during translation, addressing prior mistranslation issues while keeping metavariable labels like <file> / <path> translatable via explicit translator guidance.
Changes:
- Adds
{Locked="..."}translator metadata to severalnativeStrings.jsonentries (including#include/includePath/compile_commands.json/configurationProvider). - Adds
Lockedmetadata to one debugger warning string viavscode-nlscommentusage. - Converts several
package.nls.jsonentries to{ message, comment }form to lock boolean literals and other technical tokens, and adds guidance for translatable metavariables.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Extension/src/nativeStrings.json | Wraps specific native strings in { text, hint } to add lock metadata and translator guidance. |
| Extension/src/Debugger/debugAdapterDescriptorFactory.ts | Adds vscode-nls comment metadata to lock a setting name and boolean literal in a warning message. |
| Extension/package.nls.json | Converts selected package strings to { message, comment } and adds lock metadata for technical literals/booleans (plus metavariable guidance). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sean McManus (sean-mcmanus)
marked this pull request as ready for review
August 11, 2026 02:06
Bob Brown (bobbrow)
approved these changes
Aug 11, 2026
Sean McManus (sean-mcmanus)
deleted the
seanmcm/devbox2-wsl/agent4/lock-localization-literals
branch
August 11, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds localization metadata to preserve technical literals that were mistranslated in #14662, including
#include, configuration names, boolean values, and command-line option prefixes. Thefileandpathmetavariable labels inside angle brackets remain translatable and include explicit translator guidance.The
useForBreakpointsdescription is also rephrased from sentence-initial “False”/“True” wording to lowercasefalse/trueliterals so those values can be locked consistently.Validation