Skip to content

Lock localization literals - #14664

Merged
Sean McManus (sean-mcmanus) merged 1 commit into
mainfrom
seanmcm/devbox2-wsl/agent4/lock-localization-literals
Aug 11, 2026
Merged

Lock localization literals#14664
Sean McManus (sean-mcmanus) merged 1 commit into
mainfrom
seanmcm/devbox2-wsl/agent4/lock-localization-literals

Conversation

@sean-mcmanus

@sean-mcmanus Sean McManus (sean-mcmanus) commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds localization metadata to preserve technical literals that were mistranslated in #14662, including #include, configuration names, boolean values, and command-line option prefixes. The file and path metavariable labels inside angle brackets remain translatable and include explicit translator guidance.

The useForBreakpoints description is also rephrased from sentence-initial “False”/“True” wording to lowercase false/true literals so those values can be locked consistently.

Validation

  • Exported and inspected all affected XLF metadata
  • Regenerated native localization artifacts and verified native message text was unchanged
  • Ran focused ESLint and the Extension TypeScript build

This PR was investigated and created by GitHub Copilot in VS Code. Any message starting with ✨Copilot: was sent by Copilot.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates localization metadata so technical literals (e.g., #include, configuration/setting names, boolean literals, and option prefixes) are preserved during translation, addressing prior mistranslation issues while keeping metavariable labels like <file> / <path> translatable via explicit translator guidance.

Changes:

  • Adds {Locked="..."} translator metadata to several nativeStrings.json entries (including #include / includePath / compile_commands.json / configurationProvider).
  • Adds Locked metadata to one debugger warning string via vscode-nls comment usage.
  • Converts several package.nls.json entries to { message, comment } form to lock boolean literals and other technical tokens, and adds guidance for translatable metavariables.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Extension/src/nativeStrings.json Wraps specific native strings in { text, hint } to add lock metadata and translator guidance.
Extension/src/Debugger/debugAdapterDescriptorFactory.ts Adds vscode-nls comment metadata to lock a setting name and boolean literal in a warning message.
Extension/package.nls.json Converts selected package strings to { message, comment } and adds lock metadata for technical literals/booleans (plus metavariable guidance).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Extension/package.nls.json
@sean-mcmanus
Sean McManus (sean-mcmanus) marked this pull request as ready for review August 11, 2026 02:06
@sean-mcmanus
Sean McManus (sean-mcmanus) requested a review from a team as a code owner August 11, 2026 02:06
@sean-mcmanus
Sean McManus (sean-mcmanus) merged commit 0ec5075 into main Aug 11, 2026
7 checks passed
@sean-mcmanus
Sean McManus (sean-mcmanus) deleted the seanmcm/devbox2-wsl/agent4/lock-localization-literals branch August 11, 2026 17:00
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants