Add site-packages watchers#1597
Open
edvilme wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.sync.mp4
This pull request refactors and centralizes the logic for watching Python package changes across different environment managers (system, conda, poetry). The new approach introduces a shared utility to handle file system watching for package metadata, ensuring more robust and consistent package refresh behavior when environments change.
Key improvements and changes:
Centralized Package Watcher Logic:
packageWatcher.ts, which provideswatchPackageChangesForEnvironmentandregisterPackageWatcherForManagerto handle file watching and package refresh for any environment manager. This replaces duplicated logic in each manager.Refactoring of Environment Managers:
main.tsfiles for system, conda, and poetry managers to use the newregisterPackageWatcherForManagerfunction, removing their own package watcher and debounce logic. This simplifies each manager and ensures consistency. [1] [2] [3] [4] [5] [6]Improved Robustness and Maintainability:
Platform and Environment Awareness: