Fix #1599: onDidChangePythonProjects never fires on runtime project a…#1641
Open
mohityadav8 wants to merge 1 commit into
Open
Fix #1599: onDidChangePythonProjects never fires on runtime project a…#1641mohityadav8 wants to merge 1 commit into
mohityadav8 wants to merge 1 commit into
Conversation
…project add/remove
mohityadav8
force-pushed
the
fix-ondidchange-python-projects-not-firing
branch
from
July 19, 2026 10:21
58e3d18 to
8798be4
Compare
mohityadav8
marked this pull request as ready for review
July 19, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1599 —
PythonEnvironmentApi.onDidChangePythonProjectsnever fired when projects were added or removed at runtime. The internal project list updated correctly, but the public event was never forwarded, so consumers (notably Pylance's per-folder interpreter support) never got notified and required a restart to pick up new projects.Root cause
PythonEnvironmentApiImpl's constructor subscribed to environment-change events but never subscribed toprojectManager.onDidChangeProjects, so_onDidChangePythonProjects.fire(...)was never called.Fix
previousProjectsfield onPythonEnvironmentApiImplthat tracks the last-known project set.projectManager.onDidChangeProjectsin the constructor. On each internal change, compute the added/removed delta by diffing project URIs against the previous snapshot, update the snapshot, and fire_onDidChangePythonProjectswith{ added, removed }when the set actually changed.Diffing by URI (rather than relying on the manager's internal eventpayload) was needed because the manager currently emits the full projectarray rather than a delta, and
DidChangePythonProjectsEventArgsexpectsadded/removed.Testing
npm run compile— clean build.getPythonProjects()that the set updates as expected; confirmed the new subscription fires onaddPythonProject()andremovePythonProject()calls.