Dispose orphaned progress notifications behind when using progress reporting in language servers

[joyceerhl]

Environment data

• VS Code version: 1.59.0-insider
• Extension version (available under the Extensions sidebar): v2021.8.1046297456-dev
• Pylance version: v2021.7.5-pre.1
• OS and version: Windows 10
• Python version (& distribution if applicable, e.g. Anaconda): Python 3.9.6
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
• Relevant/affected Python packages and their versions: N/A
• Relevant/affected Python-related VS Code extensions and their versions: N/A
• Value of the python.languageServer setting: XXX

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]

Expected behaviour

Language server shouldn't crash. If it does progress notifications should be disposed

Actual behaviour

Steps to reproduce:

[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

1. Open a Python file

Logs

pylance.log
python.log

[karthiknadig]

Joyce Er (@joyceerhl) Can you look for the stack from one of the extension host logs that might have more detail on where the crash occurred?

/cc Jake Bailey (@jakebailey) is there a any additional logging you need here.

[jkryanchou]

+1

[jakebailey]

The log message and the python language server logs indicate that this is not Pylance, but MPLS (crashing with a stack overflow.

[karrtikr]

JK.Ryan (@jkryanchou) We have recently released a new and more performant language server called Pylance which likely solves these issues you are reporting.  You can download Pylance from the marketplace and install it alongside the core Python extension. Because our team's development efforts have shifted to support the new language server, we'd encourage you to try it out. If you try out Pylance and this issue persists, you can open an issue on the pylance-release repo.

[joyceerhl]

I have "python.languageServer": "Pylance", and the Pylance extension is installed. I'm still getting the Python Tools server crashing.

[jakebailey]

The language server must be getting set somewhere else; does the UI also say that its Pylance or Default?

[joyceerhl]

Ah thanks, Jupyter repo workspace settings still say Microsoft. I'd expect the in progress notification that is presumably put up by the Python extension to be disposed if the server crashes though.

[jakebailey]

I don't know why those are even showing up there; the API that runs those puts the message at the bottom bar of the editor, not as a real notification. Unless opening it manually brings that up?

[joyceerhl]

Yeah so the notification sticks around in the status bar and if you click on it it shows that there's five of those progress notifications going that can't be cancelled.