Fix dangling view - #6532
Open
JohnMcPMS wants to merge 1 commit into
Open
Fix dangling view#6532JohnMcPMS wants to merge 1 commit into
JohnMcPMS wants to merge 1 commit into
Conversation
ranm-msft
approved these changes
Sep 19, 2026
ranm-msft
left a comment
ranm-msft
left a comment
Contributor
There was a problem hiding this comment.
Verified the lifetime problem rather than just the shape of the change: fileName.extension() hands back a temporary path, so the wstring_view built from its c_str() was already pointing at freed storage by the time the caller used it. Returning std::wstring and holding fileName by value closes both halves of that. The other branches were returning literals, so they were never at risk.
Nothing else from me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Fonts added a dynamic extension without changing the return from view to string.
Microsoft Reviewers: Open in CodeFlow