feat(perf): show dynamic input dims as dynamic(<actual>) in model info#1055
Merged
Conversation
Contributor
Author
|
tested on
|
ziyuanguo1998
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pre-benchmark model-info output previously printed dynamic input dimensions as
None, which was ambiguous — it didn't convey that the axis was free, nor what size the generated benchmark data actually used.This changes dynamic dims to render as
dynamic(<actual>):Before
After
The value in parentheses is the concrete size the generated input tensor actually used for that axis (e.g. the resolved batch size), so both facts stay visible: the model left the axis free, and the benchmark ran it at size N.
Changes
_format_input_shape(shape, actual)— maps eachNonedim todynamic(<actual>), falling back to baredynamicwhen no concrete shape is available; static dims are unchanged._print_model_infogained anactual_shapesparam, threaded fromself._inputs(name → realarr.shape) at the call site.TestFormatInputShapecovering single/multiple dynamic dims, all-static, and the no-actual fallback.Close #1052