Milestone 1: Python 3.12 Modernization with Type Safety and Testing by mcode-app-dev[bot] · Pull Request #3 · mintzer/Python-Tetris-Game-Pygame

Add pyproject.toml with dependencies and tool config, add .gitignore

mcode-bot

committed

Add type annotations and fix code quality issues across all source files

mcode-bot

committed

Add pytest test suite with conftest, test_grid, test_block, test_game

mcode-bot

committed

Fix: add [build-system] table to pyproject.toml and lock_block tests to test_game.py

mcode-bot

committed

Fix: correct build-backend to setuptools.build_meta in pyproject.toml

mcode-bot

committed

Normalize line endings per .gitattributes (no content changes)

mcode-bot

committed

Fix review issue #1: Remove duplicate sys.path.insert from test files (conftest.py already handles it)

mcode-bot

committed

Fix review issue #3: Move sys.path.insert to top of conftest.py before pygame setup

mcode-bot

committed

Fix review issue #2: Add random.seed(42) to conftest.py for deterministic block sequences

mcode-bot

committed

Fix review issue #5: Extract zeroed_lblock pytest fixture to eliminate repeated offset reset in test_block.py

mcode-bot

committed

Fix review issue #6: Remove redundant local re-import of block types inside test_get_random_block_removes_from_bag

mcode-bot

committed

Fix review issue #4: Replace repeated block list literals with _all_blocks() factory in game.py and _fresh_bag() helper in test_game.py

mcode-bot

committed

Fix review issue #7: Add unit tests for move_left, move_right, move_down, rotate, and reset in Game

mcode-bot

committed

Fix review issue #8: Add cell layout assertion tests for all 6 remaining block subclasses (JBlock, IBlock, OBlock, SBlock, TBlock, ZBlock)

mcode-bot

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Milestone 1: Python 3.12 Modernization with Type Safety and Testing#3

Milestone 1: Python 3.12 Modernization with Type Safety and Testing#3
mintzer merged 14 commits into
morph-mainfrom
python-tetris-game-pygame-milestone_1-fb2e2d

Commits on Jun 29, 2026

Add pyproject.toml with dependencies and tool config, add .gitignore

Add type annotations and fix code quality issues across all source files

Add pytest test suite with conftest, test_grid, test_block, test_game

Fix: add [build-system] table to pyproject.toml and lock_block tests to test_game.py

Fix: correct build-backend to setuptools.build_meta in pyproject.toml

Normalize line endings per .gitattributes (no content changes)

Fix review issue #1: Remove duplicate sys.path.insert from test files (conftest.py already handles it)

Fix review issue #3: Move sys.path.insert to top of conftest.py before pygame setup

Fix review issue #2: Add random.seed(42) to conftest.py for deterministic block sequences

Fix review issue #5: Extract zeroed_lblock pytest fixture to eliminate repeated offset reset in test_block.py

Fix review issue #6: Remove redundant local re-import of block types inside test_get_random_block_removes_from_bag

Fix review issue #4: Replace repeated block list literals with _all_blocks() factory in game.py and _fresh_bag() helper in test_game.py

Fix review issue #7: Add unit tests for move_left, move_right, move_down, rotate, and reset in Game

Fix review issue #8: Add cell layout assertion tests for all 6 remaining block subclasses (JBlock, IBlock, OBlock, SBlock, TBlock, ZBlock)