ci: add missing backslash-variant artifact path for test-results.ndjson - #395
Conversation
CodeRabbit re-review on PR #394 caught a real, pre-existing gap (not introduced by this branch): "Upload test logs" listed only the forward-slash tests/~test-results.ndjson, missing its required backslash sibling tests\~test-results.ndjson -- every other entry in that path list carries both spellings per this repo's own convention (AGENTS.md: "any new observable ... artifact path added ... using both existing slash-style variants"). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015xbWLPbiaKVsobB9FZy8kS
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (8)
🧰 Additional context used📓 Path-based instructions (2).github/workflows/**/*.{yml,yaml}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
.github/workflows/*.yml📄 CodeRabbit inference engine (AGENTS.md)
Files:
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe batch-check workflow’s “Upload test logs” artifact configuration now includes ChangesBatch test log collection
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Downloaded the diag.conda.available NDJSON row from PR #395's merge run and confirmed available=true, verifying the staged conda_avail relocation (PR #394) works as designed. Read-only verification only; step 2 (wiring the 27 if: conditions) still needs its own separate owner sign-off per the existing reasoning. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015xbWLPbiaKVsobB9FZy8kS
) Downloaded the diag.conda.available NDJSON row from PR #395's merge run and confirmed available=true, verifying the staged conda_avail relocation (PR #394) works as designed. Read-only verification only; step 2 (wiring the 27 if: conditions) still needs its own separate owner sign-off per the existing reasoning. Claude-Session: https://claude.ai/code/session_015xbWLPbiaKVsobB9FZy8kS Co-authored-by: Claude <noreply@anthropic.com>
Summary
Follow-up to #394 (already merged), addressing a CodeRabbit re-review finding that landed after that PR's CI run started (so it's shipping as its own small, one-line commit rather than being squeezed into an already-in-flight run).
d5efdacci: add missing backslash-variant artifact path for test-results.ndjson..github/workflows/batch-check.yml's "Upload test logs" step listedtests/~test-results.ndjson(forward-slash) but was missing its required backslash siblingtests\~test-results.ndjson. This is a real, pre-existing gap (not introduced by ci: relocate conda_avail (unwired) + repo-wide ASCII cleanup #394 -- that PR only relocated an unrelated diagnostic step elsewhere in the file) -- every other entry in that same path list carries both spellings, per this repo's own convention (AGENTS.md: "any new observable log line, disk file, or assertion-detectable behavior must produce an NDJSON row and have its artifact path added to thebatch-check.ymltest-logs upload using both existing slash-style variants").Test plan
python -m compileall -q .python -m pyflakes .python tools/check_delimiters.py run_setup.batmarkdownlint-cli2 CLAUDE.md(clean, only the expected permanent baseline finding)python -m yamllint .github/workflows/actionlint -oneline .github/workflows/*.ymlpython -m pytest tests/test_*.py -q(437 passed, 2 skipped)tools/run_sanity_sweep.shrun, all checks OKClaude-Session: https://claude.ai/code/session_015xbWLPbiaKVsobB9FZy8kS
Generated by Claude Code