Skip to content

ci: add missing backslash-variant artifact path for test-results.ndjson - #395

Merged
mixmansoundude merged 1 commit into
mainfrom
claude/pipreqs-fallback-maintenance-49jhr9
Jul 27, 2026
Merged

ci: add missing backslash-variant artifact path for test-results.ndjson#395
mixmansoundude merged 1 commit into
mainfrom
claude/pipreqs-fallback-maintenance-49jhr9

Conversation

@mixmansoundude

Copy link
Copy Markdown
Owner

Summary

Follow-up to #394 (already merged), addressing a CodeRabbit re-review finding that landed after that PR's CI run started (so it's shipping as its own small, one-line commit rather than being squeezed into an already-in-flight run).

  • d5efdac ci: add missing backslash-variant artifact path for test-results.ndjson. .github/workflows/batch-check.yml's "Upload test logs" step listed tests/~test-results.ndjson (forward-slash) but was missing its required backslash sibling tests\~test-results.ndjson. This is a real, pre-existing gap (not introduced by ci: relocate conda_avail (unwired) + repo-wide ASCII cleanup #394 -- that PR only relocated an unrelated diagnostic step elsewhere in the file) -- every other entry in that same path list carries both spellings, per this repo's own convention (AGENTS.md: "any new observable log line, disk file, or assertion-detectable behavior must produce an NDJSON row and have its artifact path added to the batch-check.yml test-logs upload using both existing slash-style variants").

Test plan

  • python -m compileall -q .
  • python -m pyflakes .
  • python tools/check_delimiters.py run_setup.bat
  • markdownlint-cli2 CLAUDE.md (clean, only the expected permanent baseline finding)
  • python -m yamllint .github/workflows/
  • actionlint -oneline .github/workflows/*.yml
  • Repo-wide ASCII sweep -- clean
  • PowerShell AST parse sweep (tests/.ps1, tools/.ps1)
  • python -m pytest tests/test_*.py -q (437 passed, 2 skipped)
  • Full tools/run_sanity_sweep.sh run, all checks OK

Claude-Session: https://claude.ai/code/session_015xbWLPbiaKVsobB9FZy8kS


Generated by Claude Code

CodeRabbit re-review on PR #394 caught a real, pre-existing gap (not
introduced by this branch): "Upload test logs" listed only the
forward-slash tests/~test-results.ndjson, missing its required
backslash sibling tests\~test-results.ndjson -- every other entry in
that path list carries both spellings per this repo's own convention
(AGENTS.md: "any new observable ... artifact path added ... using
both existing slash-style variants").

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015xbWLPbiaKVsobB9FZy8kS
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@mixmansoundude
mixmansoundude enabled auto-merge (squash) July 27, 2026 12:36
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1ff7a027-457d-40cb-bff3-7436122b00bd

📥 Commits

Reviewing files that changed from the base of the PR and between 0038b60 and d5efdac.

📒 Files selected for processing (1)
  • .github/workflows/batch-check.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (8)
  • GitHub Check: auto_merge
  • GitHub Check: Batch syntax/run check (justme-test)
  • GitHub Check: Batch syntax/run check (conda-full)
  • GitHub Check: Batch syntax/run check (contract-uv-fail)
  • GitHub Check: Batch syntax/run check (uv)
  • GitHub Check: Batch syntax/run check (contract-uv)
  • GitHub Check: Batch syntax/run check (uv-dl-fallback)
  • GitHub Check: Batch syntax/run check (real)
🧰 Additional context used
📓 Path-based instructions (2)
.github/workflows/**/*.{yml,yaml}

📄 CodeRabbit inference engine (CLAUDE.md)

.github/workflows/**/*.{yml,yaml}: Validate workflow changes with both actionlint and yamllint; preserve correct lane gating and avoid silently weakening gating steps with continue-on-error.
Keep NDJSON row emission synchronized with docs/agent-ndjson.md and run the registry checker when workflow or test emission sites change.

Files:

  • .github/workflows/batch-check.yml
.github/workflows/*.yml

📄 CodeRabbit inference engine (AGENTS.md)

.github/workflows/*.yml: Do not change GitHub Actions workflow triggers, permissions, or retention settings.
Isolate slow, flaky, or environment-dependent diagnostics in their own non-gating (continue-on-error) lane instead of slowing deterministic gating lanes.
Keep the CI interface synchronized with bootstrapper messages and status summaries; update workflow parsers whenever emitted text changes, and vice versa.
Use only the single inline model path in batch-check.yml for future model work; do not add older online-model or extra inline experiments.

Files:

  • .github/workflows/batch-check.yml
🔇 Additional comments (1)
.github/workflows/batch-check.yml (1)

1888-1888: LGTM!


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated automated test log collection to include an additional test results file in uploaded artifacts.
    • No changes to application functionality or user-facing behavior.

Walkthrough

The batch-check workflow’s “Upload test logs” artifact configuration now includes tests\~test-results.ndjson alongside the existing uploaded test logs.

Changes

Batch test log collection

Layer / File(s) Summary
Include test results in uploaded logs
.github/workflows/batch-check.yml
The “Upload test logs” artifact includes tests\~test-results.ndjson.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the PR’s main change: adding the missing backslash-variant artifact path for test-results.ndjson.
Description check ✅ Passed The description is clearly related to the same CI artifact-path fix and matches the change summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/pipreqs-fallback-maintenance-49jhr9

Comment @coderabbitai help to get the list of available commands.

@mixmansoundude
mixmansoundude merged commit fb00ac6 into main Jul 27, 2026
16 checks passed
@mixmansoundude
mixmansoundude deleted the claude/pipreqs-fallback-maintenance-49jhr9 branch July 27, 2026 14:08
mixmansoundude pushed a commit that referenced this pull request Jul 27, 2026
Downloaded the diag.conda.available NDJSON row from PR #395's merge
run and confirmed available=true, verifying the staged conda_avail
relocation (PR #394) works as designed. Read-only verification only;
step 2 (wiring the 27 if: conditions) still needs its own separate
owner sign-off per the existing reasoning.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015xbWLPbiaKVsobB9FZy8kS
mixmansoundude added a commit that referenced this pull request Jul 27, 2026
)

Downloaded the diag.conda.available NDJSON row from PR #395's merge
run and confirmed available=true, verifying the staged conda_avail
relocation (PR #394) works as designed. Read-only verification only;
step 2 (wiring the 27 if: conditions) still needs its own separate
owner sign-off per the existing reasoning.


Claude-Session: https://claude.ai/code/session_015xbWLPbiaKVsobB9FZy8kS

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants