fix: AllUsers timeout vs. failure distinction; audit-tool redirect/%* gaps

[mixmansoundude]

Summary

PR #405 merged before this follow-up commit (already reviewed and confirmed-addressed by
CodeRabbit on that PR) could be pushed, per this session's "one fix per CI run, don't push while
CI is in progress" constraint. Rebased cleanly onto the new main (#405's squash-merge tip) with
no conflicts; this PR carries only that leftover, already-reviewed work.

run_setup.bat: :run_installer_timeout hardcodes its return code to 1 on a genuine
60-minute timeout (a sentinel, not the installer's real exit code) -- the AllUsers WARN was
presenting that sentinel as exitCode=1 alongside reason=installer_failed, misclassifying a
timeout as a normal installer failure. Stopped clearing the subroutine's own
HP_INSTALLER_TIMEDOUT flag before it returns (each call re-sets it fresh at entry, so leaving it
live across exit /b is safe for every caller), captured it into a new
HP_CONDA_ALLUSERS_TIMEDOUT right alongside HP_CONDA_ALLUSERS_RC, and branch the WARN: on a
real timeout it now reports reason=timeout with no fabricated exitCode field; unchanged
exitCode=..., reason=installer_failed wording otherwise. Demo doc and
docs/agent-closed-backlog.md updated to match.

tests/selfapps_justme.ps1: the failedWordingAbsent negative assertion had silently
degraded into one that could never fail -- it matched the exact pre-exitCode-annotation
sentence (from an earlier PR #404 fix), which no longer appears anywhere verbatim now that the
WARN always carries a suffix. Matches the stable Miniconda AllUsers install failed message
prefix instead, so it once again actually catches a skip-path regression.

tools/audit_console_messages.py: normalize() now handles %* (all positional
arguments), alongside the existing %~dp0/%1-style handling. extract_records's
redirect-skip is now escape-aware: it correctly skips a genuine trailing >/>> file redirect
(several existing lines -- JSON status writes, simulated-failure marker files -- were previously
NOT being skipped, since the old check only looked for >>), while still preserving a
caret-escaped redirect belonging to a nested command (e.g. a powershell subprocess's own
2^>nul) and a literal >= inside real message text (e.g. "running (>=30 days since last
update)") -- both of which a naive single-> check would have wrongly treated as a redirect and
silently dropped from the audit. 7 new regression tests across both changes.

Declined one CodeRabbit finding on this round (dedicated CI coverage for the AllUsers
attempted-failure/timeout branches via a new test-only failure hook) as new-feature scope
disproportionate to a review-comment quick-fix pass, per CLAUDE.md's own iteration-loop rule --
reasoning posted on PR #405.

Test plan

• python -m compileall -q . / pyflakes -- clean
• python tools/check_delimiters.py run_setup.bat -- clean
• ASCII sweep, yamllint, actionlint -- all clean
• pwsh AST parse sweep over all .ps1 files -- clean
• python -m pytest tests/test_*.py -q -- 453 passed, 2 skipped
• git diff --stat against current origin/main reviewed for scope (6 files, matches the
  one carried-over commit exactly)
• Manually traced every >/>> occurrence in current echo/call :log lines in
  run_setup.bat (11 cases) against the new redirect-detection regex before landing

---

Generated by Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes

  • Improved Miniconda installation diagnostics by distinguishing timeouts from installer failures.
  • Timeout messages no longer show misleading exit codes and correctly continue to the JustMe fallback.
  • Failure messages retain the installer’s actual exit code when available.
  • Improved detection of redirected console output and literal >= text during message auditing.

• Documentation

  • Documented timeout-specific installation behavior and resulting log messages.
  • Updated backlog and open-question documentation with current recovery and decision details.

• Tests

  • Expanded coverage for installation warnings, argument handling, and console message parsing.

Walkthrough

The change distinguishes Miniconda installer timeouts from exit-code failures, updates fallback diagnostics and regression assertions, documents the timeout path, improves batch console-message auditing, and records backlog and open-question updates.

Changes

Installer, console, and project records

Layer / File(s)	Summary
Miniconda timeout fallback diagnostics run_setup.bat, tests/selfapps_justme.ps1, docs/agent-closed-backlog.md, docs/demo-bootstrapper-output.md	The installer preserves timeout state and reports either reason=timeout or the actual exit code before the JustMe retry. Tests and documentation cover the updated wording and timeout path.
Console-message audit parsing tools/audit_console_messages.py, tests/test_audit_console_messages.py	The audit detects real redirects, handles caret-escaped redirects and literal >= text, and normalizes %*. Tests cover these cases.
Backlog and open-question records CLAUDE.md, docs/open-questions.md, docs/demo-bootstrapper-output.md	The records update backlog numbering guidance, add cache corruption tracking, and revise open-question status entries.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant MinicondaInstaller
  participant run_setup
  participant JustMeInstaller
  MinicondaInstaller->>run_setup: Return timeout or exit code
  run_setup->>run_setup: Preserve timeout state
  run_setup->>JustMeInstaller: Log result and retry

Loading

Possibly related PRs

• mixmansoundude/Python_vs_Windows#401: Both document the Miniconda AllUsers to JustMe fallback path.
• mixmansoundude/Python_vs_Windows#404: Both update installer fallback logic and console auditing.
• mixmansoundude/Python_vs_Windows#405: Both modify installer fallback logging, tests, documentation, and audit tooling.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 15.38% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the two main changes: distinguishing AllUsers timeouts from failures and fixing audit-tool redirect and %* handling.
Description check	✅ Passed	The description directly explains the implementation changes, related documentation updates, regression tests, and validation results.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/bootstrapper-execution-branches-ox2izi

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@run_setup.bat`:
- Around line 4517-4532: Add CI coverage for the AllUsers retry logging around
the tci_justme branch, using deterministic scenarios for both
HP_CONDA_ALLUSERS_TIMEDOUT=1 and a non-timeout installer failure. Assert timeout
logs include reason=timeout without exitCode, installer failures include
reason=installer_failed with the exit code, and emit NDJSON telemetry for both
scenarios.
- Around line 4478-4482: Update :run_installer_timeout to validate the helper’s
returned status before interpreting its result, and accept only a complete
result record matching <integer exitCode>|<0|1>. Treat missing, malformed, or
unsuccessful-helper results as indeterminate, preserve the timeout signaling,
and return without launching the fallback installer through :tci_justme.

In `@tests/test_audit_console_messages.py`:
- Around line 72-90: Add a test in tests/test_audit_console_messages.py covering
a redirect in a later command segment, such as call :log followed by an
ampersand and echo redirect. Assert through extract_records that the call :log
message remains in the returned records, ensuring suffix-scanning logic is
exercised.

In `@tools/audit_console_messages.py`:
- Around line 88-95: Update extract_records in tools/audit_console_messages.py
to detect redirects only when they are unquoted, not caret-escaped, and occur
within the same command segment as the call :log, preventing later commands from
discarding the record. Add one regression test in
tests/test_audit_console_messages.py covering both a valid same-segment redirect
and a later-command redirect, then run the test with pytest.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 01d2daf5-b7b5-4acf-9899-2ba6783b6165

📥 Commits

Reviewing files that changed from the base of the PR and between d3763f3 and de9fd37.

📒 Files selected for processing (6)

• docs/agent-closed-backlog.md
• docs/demo-bootstrapper-output.md
• run_setup.bat
• tests/selfapps_justme.ps1
• tests/test_audit_console_messages.py
• tools/audit_console_messages.py

📜 Review details

⏰ Context from checks skipped due to timeout. (10)

• GitHub Check: auto_merge
• GitHub Check: analyze
• GitHub Check: Batch syntax/run check (contract-uv-fail)
• GitHub Check: Batch syntax/run check (conda-full)
• GitHub Check: Batch syntax/run check (real)
• GitHub Check: Batch syntax/run check (cache)
• GitHub Check: Batch syntax/run check (uv-dl-fallback)
• GitHub Check: Batch syntax/run check (uv)
• GitHub Check: Batch syntax/run check (contract-uv)
• GitHub Check: Batch syntax/run check (justme-test)

🧰 Additional context used

📓 Path-based instructions (12)

**/*

📄 CodeRabbit inference engine (CLAUDE.md)

**/*: Use ASCII-only characters in repository files; avoid emojis, curly quotes, and em-dashes because Windows batch/CMD parsing can break on non-ASCII characters.
Implement exactly one missing feature slice and add exactly one missing test per iteration loop; freeze scope and defer new requirements to the backlog.
When a change teaches or invalidates a lesson, update the relevant knowledge document in the same commit; move fully resolved Active Backlog items to docs/agent-closed-backlog.md.

The single-bootstrapper directive requires run_setup.bat to work when dropped next to the application without committed helper files; test-only helpers may live under tests/ but cannot be required by the real flow.

Files:

• tests/selfapps_justme.ps1
• docs/demo-bootstrapper-output.md
• tests/test_audit_console_messages.py
• docs/agent-closed-backlog.md
• tools/audit_console_messages.py
• run_setup.bat

**/*.{bat,ps1}

📄 CodeRabbit inference engine (CLAUDE.md)

Use CRLF line endings for .bat and .ps1 files; use LF for other files, as controlled by .gitattributes.

Files:

• tests/selfapps_justme.ps1
• run_setup.bat

tests/selfapps_*.ps1

📄 CodeRabbit inference engine (CLAUDE.md)

Add PowerShell scenario tests using the tests/selfapps_<scenario>.ps1 naming convention and wire new scenarios into tests/harness.ps1 and the CI workflow.

Files:

• tests/selfapps_justme.ps1

**/*.{ps1,psm1,psd1}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ps1,psm1,psd1}: Prepend TLS 1.2 configuration to every PowerShell 5.1 Invoke-WebRequest call and retain -UseBasicParsing.
Validate touched PowerShell files with PowerShell AST parsing; do not skip validation on Linux, and run modified scripts directly with realistic environment variables when practical.

Files:

• tests/selfapps_justme.ps1

**/*.{bat,cmd,ps1,py,yml,yaml,json}

📄 CodeRabbit inference engine (AGENTS.md)

Run delimiter and repository-specific syntax regression checks using tools/check_delimiters.py, respecting comments, escapes, and here-strings as applicable.

Files:

• tests/selfapps_justme.ps1
• tests/test_audit_console_messages.py
• tools/audit_console_messages.py
• run_setup.bat

**/*.{py,ps1,psm1,psd1,yml,yaml,json,bat,cmd}

📄 CodeRabbit inference engine (AGENTS.md)

Keep source text ASCII plain text and avoid non-ASCII punctuation.

Files:

• tests/selfapps_justme.ps1
• tests/test_audit_console_messages.py
• tools/audit_console_messages.py
• run_setup.bat

**/*.{md,txt}

📄 CodeRabbit inference engine (AGENTS.md)

When documenting run_setup.bat, cite labels or subroutine names rather than exact line numbers unless a line number provides immediate value for the introducing commit.

Files:

• docs/demo-bootstrapper-output.md
• docs/agent-closed-backlog.md

**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

Add Python unit tests under tests/test_<topic>.py and run them with pytest.

Files:

• tests/test_audit_console_messages.py
• tools/audit_console_messages.py

**/*.{py,sh}

📄 CodeRabbit inference engine (AGENTS.md)

Use python -m compileall -q ., python -m pyflakes ., and the canonical pipreqs command pipreqs . --force --mode compat --savepath requirements.auto.txt for relevant sanity checks.

Files:

• tests/test_audit_console_messages.py
• tools/audit_console_messages.py

**/*.bat

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.bat: In batch files, invoke conda through call "%CONDA_BAT%" ... so the parent batch script continues running.
Avoid EnableDelayedExpansion in batch logic; if required, scope it tightly because parent shells may run with /V:ON and cause variable collisions.
Pass --override-channels -c conda-forge on every conda installation command to prevent defaults-channel contamination.
Use tilde-prefixed temporary files such as ~setup.log and ~bootstrap.status.json so they are easy to ignore and survive crashes.
Do not rely on console scripts during bootstrap; invoke tools through explicit interpreter paths or direct Python module/API calls.
Anchor every bootstrap tool invocation to an explicit Python executable such as %HP_PY% or %CONDA_PREFIX%\python.exe; never rely on PATH or activation to select the interpreter.
Bootstrap must fail fast and explicitly when interpreter, environment, or dependency availability cannot be guaranteed; do not use silent fallbacks unless they are explicitly logged.
Keep non-obvious bootstrap constraints documented inline with comments such as # derived requirement: <why>, including why deterministic module invocation is used instead of a console script.

Files:

• run_setup.bat

run_setup.bat

📄 CodeRabbit inference engine (CLAUDE.md)

run_setup.bat: Keep run_setup.bat self-contained: do not add committed helper files; embed helpers as base64 payloads under :define_helper_payloads, refreshing them with tools/sync_payload.py rather than manually encoding or splicing them.
Run python tools/check_delimiters.py run_setup.bat after every edit to run_setup.bat.
Ensure every bootstrap run writes ~bootstrap.status.json with state ok, no_python_files, or error, plus exitCode and pyFiles fields.

run_setup.bat: Every branch added to run_setup.bat or related helpers must have a CI test, including feature flags, fallback and recovery paths, and fast versus full paths; add an NDJSON assertion and a dedicated lane or HP_* flag when necessary.
All embedded helpers must remain base64 payloads under :define_helper_payloads; changing a payload requires updating the matching HP_* line from its canonical tools/ source.
Do not remove tilde prefixes from runtime artifact files such as ~bootstrap.status.json, ~setup.log, ~environment.lock.txt, and ~env.state.json.
Treat unknown ~env.state.json schemas as stale and trigger a full rebuild rather than reporting an error.
Update [VERSION_METADATA] after CI verifies a newer Windows, PowerShell, or Python environment, including the verification date and current versions.

Files:

• run_setup.bat

**/*.{bat,cmd}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{bat,cmd}: For batch assignments use set "VAR=value", never set VAR="value"; quote %VAR% at every filesystem call site, except NSIS /D= parameters, which must remain /D=%VAR%.
Before system-wide installation, silently check elevation with fsutil dirty query %systemdrive% >nul 2>&1; on failure, skip the system-wide path and fall back to per-user installation.
Avoid EnableDelayedExpansion unless it is strictly scoped, and disable it afterward; use careful quoting and escaping rather than silencing errors.
Use tools/sync_payload.py as the only sanctioned method for re-encoding embedded HP_* payload lines after editing canonical helper sources; run delimiter checks after payload changes.

Files:

• run_setup.bat

🔇 Additional comments (6)

run_setup.bat (1)

4494-4494: LGTM!

docs/agent-closed-backlog.md (1)

531-553: LGTM!

docs/demo-bootstrapper-output.md (1)

1558-1565: LGTM!

tests/selfapps_justme.ps1 (1)

63-76: 🎯 Functional Correctness

No change required.

tests/selfapps_envsmoke.ps1 removes tests/~envsmoke/~setup.log before running run_setup.bat, so failedWordingAbsent does not read stale output.

			> Likely an incorrect or invalid review comment.

tools/audit_console_messages.py (1)

11-14: LGTM!

Also applies to: 45-61

tests/test_audit_console_messages.py (1)

30-31: LGTM!

Also applies to: 60-69

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CLAUDE.md`:
- Around line 488-489: Replace the future-dated 2026-08-01 references with the
correct non-future dates: update the owner-decision entry at CLAUDE.md lines
488-489, the cache-diagnosis entry at CLAUDE.md lines 698-699 and
docs/open-questions.md line 14, and the Known Findings decision at CLAUDE.md
lines 939-940. Preserve the surrounding wording and ensure each date reflects
when the decision or diagnosis actually occurred.

In `@docs/open-questions.md`:
- Around line 30-35: Remove the resolved cascade-consent design question and its
explanatory references from the open-questions document, leaving the decision
recorded only in the referenced knowledge documents and preserving the file’s
focus on unanswered questions.

In `@tools/audit_console_messages.py`:
- Around line 52-56: Update SEGMENT_END_RE in tools/audit_console_messages.py to
recognize command separators only when preceded by an even number of consecutive
carets, so ^^& and ^^| remain active separators while odd-parity escapes do not.
Add regression coverage for ^^& and ^^| in tests/test_audit_console_messages.py,
preserving existing separator and redirect behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1f895f82-96d5-4f93-be7b-48a50c10a4c6

📥 Commits

Reviewing files that changed from the base of the PR and between de9fd37 and eda5623.

📒 Files selected for processing (5)

• CLAUDE.md
• docs/demo-bootstrapper-output.md
• docs/open-questions.md
• tests/test_audit_console_messages.py
• tools/audit_console_messages.py

📜 Review details

⏰ Context from checks skipped due to timeout. (9)

• GitHub Check: analyze
• GitHub Check: Batch syntax/run check (real)
• GitHub Check: Batch syntax/run check (conda-full)
• GitHub Check: Batch syntax/run check (contract-uv-fail)
• GitHub Check: Batch syntax/run check (uv)
• GitHub Check: Batch syntax/run check (justme-test)
• GitHub Check: Batch syntax/run check (uv-dl-fallback)
• GitHub Check: Batch syntax/run check (contract-uv)
• GitHub Check: Batch syntax/run check (cache)

🧰 Additional context used

📓 Path-based instructions (8)

**/*

📄 CodeRabbit inference engine (AGENTS.md)

The single-bootstrapper directive requires run_setup.bat to work when dropped next to the application without committed helper files; test-only helpers may live under tests/ but cannot be required by the real flow.

Files:

• docs/open-questions.md
• tests/test_audit_console_messages.py
• tools/audit_console_messages.py
• CLAUDE.md
• docs/demo-bootstrapper-output.md

**/*.{md,txt}

📄 CodeRabbit inference engine (AGENTS.md)

When documenting run_setup.bat, cite labels or subroutine names rather than exact line numbers unless a line number provides immediate value for the introducing commit.

Files:

• docs/open-questions.md
• CLAUDE.md
• docs/demo-bootstrapper-output.md

**/*.{bat,ps1,py,yml,json,md}

📄 CodeRabbit inference engine (CLAUDE.md)

Use ASCII-only content; avoid emojis, curly quotes, em-dashes, and other non-ASCII characters.

Files:

• docs/open-questions.md
• tests/test_audit_console_messages.py
• tools/audit_console_messages.py
• CLAUDE.md
• docs/demo-bootstrapper-output.md

**/*.{bat,cmd,ps1,py,yml,yaml,json}

📄 CodeRabbit inference engine (AGENTS.md)

Run delimiter and repository-specific syntax regression checks using tools/check_delimiters.py, respecting comments, escapes, and here-strings as applicable.

Files:

• tests/test_audit_console_messages.py
• tools/audit_console_messages.py

**/*.{py,ps1,psm1,psd1,yml,yaml,json,bat,cmd}

📄 CodeRabbit inference engine (AGENTS.md)

Keep source text ASCII plain text and avoid non-ASCII punctuation.

Files:

• tests/test_audit_console_messages.py
• tools/audit_console_messages.py

**/*.{py,sh}

📄 CodeRabbit inference engine (AGENTS.md)

Use python -m compileall -q ., python -m pyflakes ., and the canonical pipreqs command pipreqs . --force --mode compat --savepath requirements.auto.txt for relevant sanity checks.

Files:

• tests/test_audit_console_messages.py
• tools/audit_console_messages.py

tests/test_*.py

📄 CodeRabbit inference engine (CLAUDE.md)

Place Python unit tests in tests/test_<topic>.py and run them with pytest.

Files:

• tests/test_audit_console_messages.py

CLAUDE.md

📄 CodeRabbit inference engine (AGENTS.md)

Run the advisory MD029-only Markdown lint check on CLAUDE.md; new Active Backlog entries must be bullets with the identifier in prose rather than literal ordered-list markers.

Files:

• CLAUDE.md

🧠 Learnings (1)

📓 Common learnings

Learnt from: CR
Repo: mixmansoundude/Python_vs_Windows

Timestamp: 2026-07-31T22:07:08.038Z
Learning: Freeze scope during an iteration loop; defer new requirements to the backlog.

Learnt from: CR
Repo: mixmansoundude/Python_vs_Windows

Timestamp: 2026-07-31T22:07:08.038Z
Learning: During iteration, fix CI and test infrastructure issues before test assertions, then product code; implement exactly one missing feature and add exactly one missing test per loop.

Learnt from: CR
Repo: mixmansoundude/Python_vs_Windows

Timestamp: 2026-07-31T22:07:08.038Z
Learning: Keep knowledge documents current in the same commit when a change teaches or invalidates a lesson; edit existing entries rather than only appending.

🪛 LanguageTool

docs/open-questions.md

[grammar] ~18-~18: Ensure spelling is correct
Context: ...ix is reasoned through in item 19's own writeup (treat a restore-keys prefix-match co...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🔇 Additional comments (5)

docs/demo-bootstrapper-output.md (1)

17-36: LGTM!

Also applies to: 1572-1580

CLAUDE.md (1)

484-493: 📐 Maintainability & Code Quality

No changes required. CLAUDE.md passes the MD029-only check, and the Active Backlog entry uses a bullet with its identifier in prose.

tools/audit_console_messages.py (2)

11-14: LGTM!

---

52-75: 📐 Maintainability & Code Quality

Run the remaining checks in a complete test environment.

The delimiter check reports 19 errors outside the reviewed files. Python syntax passes, but compileall, pyflakes, pipreqs, and the focused test are not confirmed.

tests/test_audit_console_messages.py (1)

30-33: LGTM!

Also applies to: 60-71, 72-90