Docs: close Item 28 (confirmed via real CI), file Item 29 for pyproj DLL gap - #420
Conversation
PR #419's --collect-submodules pairing fix is confirmed working in real CI (cache-lane run 31256064576, on the merge commit): the strict hidden-import gate correctly added --hidden-import=numpy --collect-submodules=numpy, then --hidden-import=pyproj --collect-submodules=pyproj, for a real target never previously observed in this chain -- stronger evidence than reproducing the original packaging.version case verbatim (which this run did not hit). Moved Item 28 to docs/agent-closed-backlog.md as closed. The same run uncovered a new, one-level-deeper blocker: --collect-submodules=pyproj pulled in pyproj's own compiled extensions for the first time, surfacing 8 fresh "Library not found: could not resolve 'proj_9.dll'" build warnings that :dll_bundle_recover never had a chance to react to, since it only runs once, before the first smoke attempt -- before hidden-import recovery ever adds a new package to the build. Filed as CLAUDE.md Active Backlog Item 29. Updated docs/agent-interconnect.md and docs/agent-lessons-learned.md citations to point at Item 28's new closed-backlog location. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (3)**/*.md📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*📄 CodeRabbit inference engine (AGENTS.md)
Files:
CLAUDE.md📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (2)📓 Common learnings📚 Learning: 2026-08-01T02:27:53.952ZApplied to files:
🔇 Additional comments (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request documents the native-DLL recovery limitation after hidden-import rebuilds, records the completed hidden-import backlog item, and updates cross-document references from ChangesBacklog documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Both records listed 9 pyproj extension names but said "8 fresh" warnings. Re-verified against the real captured build log: grep -c confirms 9 distinct WARNING lines, one per listed .pyd. Corrected both counts to 9. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW
Summary
Docs-only follow-up loop on CLAUDE.md Active Backlog Item 28, per the watchdog trigger's
"continue if work to do, active backlog" instruction, and the explicit check-in ask to confirm
self.layered_e2e.chain'schainPassafter PR #419 merged.Item 28's fix is CONFIRMED working, via real CI evidence (merge commit
bd5d4df3,cache-lane run31256064576,~selftest_layered_e2e/~layered_e2e_bootstrap.logand~setup.log, pulled directly via targeted HTTP-range zip reads rather than trusting jobconclusion alone). The paired
--collect-submodules/--hidden-importmechanism fired for real,twice, in the first post-merge run:
This confirms the fix for a real target (
pyproj) never previously observed in this chain --arguably stronger evidence than reproducing the originally-investigated
packaging.versioncaseverbatim (which this particular run did not hit at all). Moved Item 28 to
docs/agent-closed-backlog.mdas closed, updating its own citations indocs/agent-interconnect.mdanddocs/agent-lessons-learned.mdto point at the new location.The same run uncovered a genuinely new, one-level-deeper blocker, filed as a fresh Active
Backlog item (Item 29): now that
--collect-submodules=pyprojbundlespyproj's own compiledextensions for the first time, the rebuild's own PyInstaller build log shows 8 fresh
Library not found: could not resolve 'proj_9.dll'warnings (one per.pyd:list,database,_version,_transformer,_sync,_network,_geod,_crs,_context). The final EXE'scaptured stderr confirms the runtime consequence:
:dll_bundle_recover(Item 24's own mechanism) never gets a chance to react to this, since itonly runs once, before the very first smoke attempt -- before
:hidden_import_recover's ownloop ever adds
pyprojto the build.mech4Pass(theeccodes.dllfix) is unaffected;mech3Pass/chainPassstayfalsebecause the chain never reaches colorama's own gap. No codechange in this loop -- root-cause investigation and backlog filing only, mirroring how Item 28's
own root cause (PR #418) was docs-only before its fix (PR #419) landed separately.
Test plan
tools/run_sanity_sweep.sh-- all clean, 515 passed / 3 skipped (docs-only change).markdownlint-cli2(not just the sanity sweep's MD029 subset) on all touched docs --clean.
run_setup.batedit, so no delimiter/payload-sync concerns.Generated by Claude Code