Skip to content

Docs: close Item 28 (confirmed via real CI), file Item 29 for pyproj DLL gap - #420

Merged
mixmansoundude merged 2 commits into
mainfrom
claude/bootstrapper-execution-branches-ox2izi
Aug 8, 2026
Merged

Docs: close Item 28 (confirmed via real CI), file Item 29 for pyproj DLL gap#420
mixmansoundude merged 2 commits into
mainfrom
claude/bootstrapper-execution-branches-ox2izi

Conversation

@mixmansoundude

Copy link
Copy Markdown
Owner

Summary

Docs-only follow-up loop on CLAUDE.md Active Backlog Item 28, per the watchdog trigger's
"continue if work to do, active backlog" instruction, and the explicit check-in ask to confirm
self.layered_e2e.chain's chainPass after PR #419 merged.

Item 28's fix is CONFIRMED working, via real CI evidence (merge commit bd5d4df3,
cache-lane run 31256064576, ~selftest_layered_e2e/~layered_e2e_bootstrap.log and
~setup.log, pulled directly via targeted HTTP-range zip reads rather than trusting job
conclusion alone). The paired --collect-submodules/--hidden-import mechanism fired for real,
twice, in the first post-merge run:

[REPAIR][HIDDEN_IMPORT] Adding --hidden-import=numpy --collect-submodules=numpy; rebuilding EXE (iter 1/3).
[REPAIR][HIDDEN_IMPORT] Adding --hidden-import=pyproj --collect-submodules=pyproj; rebuilding EXE (iter 2/3).

This confirms the fix for a real target (pyproj) never previously observed in this chain --
arguably stronger evidence than reproducing the originally-investigated packaging.version case
verbatim (which this particular run did not hit at all). Moved Item 28 to
docs/agent-closed-backlog.md as closed, updating its own citations in
docs/agent-interconnect.md and docs/agent-lessons-learned.md to point at the new location.

The same run uncovered a genuinely new, one-level-deeper blocker, filed as a fresh Active
Backlog item (Item 29): now that --collect-submodules=pyproj bundles pyproj's own compiled
extensions for the first time, the rebuild's own PyInstaller build log shows 8 fresh
Library not found: could not resolve 'proj_9.dll' warnings (one per .pyd: list, database,
_version, _transformer, _sync, _network, _geod, _crs, _context). The final EXE's
captured stderr confirms the runtime consequence:

ImportError: DLL load failed while importing _context: The specified module could not be found.

:dll_bundle_recover (Item 24's own mechanism) never gets a chance to react to this, since it
only runs once, before the very first smoke attempt -- before :hidden_import_recover's own
loop ever adds pyproj to the build. mech4Pass (the eccodes.dll fix) is unaffected;
mech3Pass/chainPass stay false because the chain never reaches colorama's own gap. No code
change in this loop -- root-cause investigation and backlog filing only, mirroring how Item 28's
own root cause (PR #418) was docs-only before its fix (PR #419) landed separately.

Test plan

  • tools/run_sanity_sweep.sh -- all clean, 515 passed / 3 skipped (docs-only change).
  • Full markdownlint-cli2 (not just the sanity sweep's MD029 subset) on all touched docs --
    clean.
  • No run_setup.bat edit, so no delimiter/payload-sync concerns.

Generated by Claude Code

PR #419's --collect-submodules pairing fix is confirmed working in real CI
(cache-lane run 31256064576, on the merge commit): the strict hidden-import
gate correctly added --hidden-import=numpy --collect-submodules=numpy, then
--hidden-import=pyproj --collect-submodules=pyproj, for a real target never
previously observed in this chain -- stronger evidence than reproducing the
original packaging.version case verbatim (which this run did not hit).

Moved Item 28 to docs/agent-closed-backlog.md as closed. The same run
uncovered a new, one-level-deeper blocker: --collect-submodules=pyproj pulled
in pyproj's own compiled extensions for the first time, surfacing 8 fresh
"Library not found: could not resolve 'proj_9.dll'" build warnings that
:dll_bundle_recover never had a chance to react to, since it only runs once,
before the first smoke attempt -- before hidden-import recovery ever adds a
new package to the build. Filed as CLAUDE.md Active Backlog Item 29.

Updated docs/agent-interconnect.md and docs/agent-lessons-learned.md
citations to point at Item 28's new closed-backlog location.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@mixmansoundude
mixmansoundude enabled auto-merge (squash) August 8, 2026 12:48
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a3eab203-1fcd-452e-aa21-654aff904592

📥 Commits

Reviewing files that changed from the base of the PR and between a62814e and 1c1cb11.

📒 Files selected for processing (2)
  • CLAUDE.md
  • docs/agent-closed-backlog.md
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (3)
**/*.md

📄 CodeRabbit inference engine (AGENTS.md)

Cite run_setup.bat locations in documentation by stable label or subroutine name rather than line number.

Files:

  • docs/agent-closed-backlog.md
  • CLAUDE.md
**/*

📄 CodeRabbit inference engine (AGENTS.md)

**/*: Keep repository text ASCII plain text and do not manually change line endings.
Push every commit before it can be lost; do not leave completed commits only in the local repository.

Files:

  • docs/agent-closed-backlog.md
  • CLAUDE.md
CLAUDE.md

📄 CodeRabbit inference engine (AGENTS.md)

New Active Backlog items must use bullets with the identifier in prose, not literal ordered-list markers; run the repository's narrow MD029 markdown check.

Files:

  • CLAUDE.md
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: mixmansoundude/Python_vs_Windows

Timestamp: 2026-08-08T12:53:59.198Z
Learning: Freeze the scope of each iteration loop; defer new requirements to the backlog, implement exactly one missing feature slice, and add exactly one missing test per loop.
Learnt from: CR
Repo: mixmansoundude/Python_vs_Windows

Timestamp: 2026-08-08T12:53:59.198Z
Learning: When a change teaches or invalidates a lesson, update the relevant knowledge document in the same commit; move fully resolved backlog items to `docs/agent-closed-backlog.md`.
📚 Learning: 2026-08-01T02:27:53.952Z
Learnt from: mixmansoundude
Repo: mixmansoundude/Python_vs_Windows PR: 408
File: docs/agent-closed-backlog.md:0-0
Timestamp: 2026-08-01T02:27:53.952Z
Learning: In the documentation files describing the removed UNC warning check in `run_setup.bat`, state only verified behavior: the check emitted `[WARN] UNC paths not supported` for an ordinary local path and was removed because the separate UNC-prefix guard already handles UNC detection. Do not assert the exact `findstr` or cmd.exe backslash-parsing mechanism, since it was not independently verified.

Applied to files:

  • docs/agent-closed-backlog.md
🔇 Additional comments (2)
CLAUDE.md (1)

533-587: LGTM!

docs/agent-closed-backlog.md (1)

1620-1656: LGTM!


📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Added backlog documentation for hidden-import recovery and its interaction with native DLL bundling.
    • Documented a limitation where DLL warnings from later recovery passes may not be detected, potentially causing DLL load failures.
    • Recorded compatibility checks, CI validation, and follow-up options for improving recovery behavior.
    • Updated cross-document references to point to the consolidated backlog records.

Walkthrough

The pull request documents the native-DLL recovery limitation after hidden-import rebuilds, records the completed hidden-import backlog item, and updates cross-document references from CLAUDE.md to docs/agent-closed-backlog.md.

Changes

Backlog documentation

Layer / File(s) Summary
Backlog item updates
CLAUDE.md, docs/agent-closed-backlog.md
Replaces the resolved backlog entry with Item 29 for the proj_9.dll recovery gap. Adds Item 28 with its implementation, CI validation, and deferred DLL limitation.
Cross-document reference alignment
docs/agent-interconnect.md, docs/agent-lessons-learned.md
Updates Item 28 and Item 29 references to use docs/agent-closed-backlog.md.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the documentation changes: closing Item 28 and filing Item 29 for the pyproj DLL gap.
Description check ✅ Passed The description directly explains the CI confirmation, backlog updates, newly observed DLL gap, and validation performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/bootstrapper-execution-branches-ox2izi

Comment @coderabbitai help to get the list of available commands.

Both records listed 9 pyproj extension names but said "8 fresh" warnings.
Re-verified against the real captured build log: grep -c confirms 9 distinct
WARNING lines, one per listed .pyd. Corrected both counts to 9.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants