Skip to content

Item 31: close Scenario 25's demo-doc quote-count shortfall - #424

Merged
mixmansoundude merged 1 commit into
mainfrom
claude/bootstrapper-execution-branches-ox2izi
Aug 9, 2026
Merged

Item 31: close Scenario 25's demo-doc quote-count shortfall#424
mixmansoundude merged 1 commit into
mainfrom
claude/bootstrapper-execution-branches-ox2izi

Conversation

@mixmansoundude

Copy link
Copy Markdown
Owner

Summary

Follow-up to PR #423's audit (CLAUDE.md Active Backlog Item 31): docs/demo-bootstrapper-output.md's
Scenario 25 (pandas/openpyxl heuristic dependency augmentation) had only 1 real console quote against
the doc's own 5-quote house-rule minimum -- the worst shortfall flagged in the audit.

  • Added a second real bootstrap-console capture, pulled from the SAME CI run/job as the scenario's
    existing evidence (self.exe.warnfix.real's own scratch directory, tests/~selftest_warnfix_real/)
    -- a full run_setup.bat run whose requirements.txt declares only pandas (triggering the same
    heuristic rule already shown) while the app itself imports openpyxl directly and prints
    wrote out.xlsx only after a real openpyxl.Workbook().save() succeeds inside the frozen EXE.
    This is direct, unambiguous proof the heuristic-installed package is genuinely bundled and usable
    at runtime, not just resolved by conda's solver. 6 new real quotes added, well past the minimum.
  • Fixed a pre-existing factual error found while sourcing this: self.exe.warnfix.real is emitted
    by tests/selfapps_warnfix.ps1, not tests/selftest.ps1 as the doc previously said (confirmed
    directly via source grep).
  • Updated CLAUDE.md's Item 31 tracking to reflect Scenario 25 as resolved (5 shortfalls remain, was 6).

No run_setup.bat changes; no code paths touched.

Test plan

  • tools/run_sanity_sweep.sh -- all clean, 515 passed / 3 skipped.
  • New quotes verified against the real CI job log (run 30328748330, job 90179708094,
    conda-full lane), downloaded and grepped directly rather than reconstructed from memory.
  • Stub app source (tests/selfapps_warnfix.ps1's real scenario) read directly to confirm
    wrote out.xlsx is genuine print() output from the app itself.

Generated by Claude Code

Scenario 25 (pandas/openpyxl heuristic augmentation) had only 1 real
console quote, the worst shortfall flagged in CLAUDE.md's Item 31 audit.
Added a second real bootstrap-console capture from the SAME CI run/job
(self.exe.warnfix.real's own scratch directory) showing the
heuristic-installed openpyxl genuinely bundled and usable in a frozen
EXE -- the stub app there declares only "pandas" in requirements.txt
(to trigger the same heuristic) but imports openpyxl directly and
prints "wrote out.xlsx" after a real openpyxl.Workbook().save() inside
the EXE, which is direct proof the heuristic-provisioned package works
at runtime, not just at conda-solve time. 6 new real quotes added,
well past the 5-quote house-rule minimum.

Also fixed a pre-existing factual error found while sourcing this:
self.exe.warnfix.real is emitted by tests/selfapps_warnfix.ps1, not
tests/selftest.ps1 as the doc previously said.

Updates CLAUDE.md Item 31's own tracking to reflect Scenario 25 as
resolved (5 shortfalls remain, was 6).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@mixmansoundude
mixmansoundude enabled auto-merge (squash) August 9, 2026 00:39
@mixmansoundude
mixmansoundude merged commit 1c35094 into main Aug 9, 2026
2 of 11 checks passed
@mixmansoundude
mixmansoundude deleted the claude/bootstrapper-execution-branches-ox2izi branch August 9, 2026 00:39
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 09fba6f9-4f4a-4a63-afcb-7a8b7c8e01c5

📥 Commits

Reviewing files that changed from the base of the PR and between 92c3a69 and 98ba7ac.

📒 Files selected for processing (2)
  • CLAUDE.md
  • docs/demo-bootstrapper-output.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated Scenario 25 test references to reflect the current validation script.
    • Added CI evidence confirming the pandas heuristic provisions openpyxl.
    • Documented successful bundled-executable creation of out.xlsx.
    • Corrected backlog reporting to show five scenarios below the quote minimum.

Walkthrough

The documentation records Scenario 25 as fixed with CI evidence for pandas heuristic provisioning, openpyxl bundling, and out.xlsx creation. The backlog updates the remaining shortfall count from six to five.

Changes

Scenario 25 documentation

Layer / File(s) Summary
Scenario 25 CI evidence
docs/demo-bootstrapper-output.md
The test reference now uses tests/selfapps_warnfix.ps1. CI evidence records openpyxl provisioning, executable creation, smoke execution, and wrote out.xlsx.
Backlog count reconciliation
CLAUDE.md
Active Backlog Item 31 records Scenario 25 as fixed and updates the remaining shortfall count from six to five.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: claude

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/bootstrapper-execution-branches-ox2izi

Comment @coderabbitai help to get the list of available commands.

mixmansoundude pushed a commit that referenced this pull request Aug 9, 2026
Closes out CLAUDE.md Active Backlog Item 31 entirely -- all 7 originally
flagged scenarios (2026-08-08 audit) now meet the 5-quote house-rule
minimum:

- "Reactive-only failure hint" (Part VIII): its own section title
  promised coverage of "both Tier A and requirement 9's real-build-
  failure paths" but only ever quoted requirement 9's. Added the
  distinct Tier A (:try_nuitka_tier_a) failure messages from source
  (both call sites, [Extrapolated Branch] since no CI run has hit a
  real Nuitka compiler failure) -- the section now actually covers
  what its title claims. 5 quotes total (was 2).

- Scenario 26 (Conda base periodic update): added the "last update <
  30 days ago" skip branch -- a real, deterministic literal string
  from source, not previously documented at all, and in practice more
  common than the "first install" skip already shown (it's what fires
  on every ordinary repeat bootstrap within the 30-day window) -- plus
  the update-failure line, previously only described in prose. 5
  quotes total (was 3).

- Scenario 41 (Interactive verification): added the PID-display line
  and the live-teed program's own real stdout (hello-from-stub),
  cross-cited from an earlier real capture in the same doc (run
  30328748330, job 90179708091) that already confirmed both as
  genuine console output belonging to this exact live-tee mechanism.
  5 quotes total (was 3).

Item 31 is now fully resolved -- moved from CLAUDE.md's Active Backlog
to docs/agent-closed-backlog.md's Closed Active Backlog Items section
(keeping its original number), consolidating the full three-PR
resolution history (#423/#424/#425) in one place.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW
mixmansoundude added a commit that referenced this pull request Aug 9, 2026
…g bug (#425)

* Item 31: close Scenario 23/36's quote shortfall, fix real ordering bug

While sourcing additional real quotes for Scenario 23/36 (both about
HP_PVW_KNOWN_IDEMPOTENT execute-mode discovery), traced the actual
call order in run_setup.bat and found the doc's own ordering claim was
wrong: it said the discovery run fires "right after entry selection
returns," but :determine_entry is genuinely called TWICE -- an early,
silent pass right after provider selection (which
:pvw_known_idempotent_run's own gate depends on), and a later one,
after the entire dependency-install phase, that's the one which
actually echoes "Chosen entry: ...". Confirmed directly against the
real captured job log (run 30328748330, job 90179708109, uv lane):
discovery fires right after "[BOOT] REQ-009: Selected Python provider:
UV.", well before any entry announcement.

Both scenarios now quote the provider-selection line before and the
real "Chosen entry"/"Entry selected" pair after, both past the 5-quote
minimum and both now factually correct about the ordering.

Updates CLAUDE.md Item 31's tracking (3 shortfalls remain, was 5).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW

* CLAUDE.md: fix Scenario 36 quote count (5 -> 6)

CodeRabbit finding on PR #425: Scenario 36's console block has 6
lines (4 in the discovery block + 2 in the Chosen entry block), same
as Scenario 23, not 5 as the tracking note said. Confirmed by direct
recount against the current file.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW

* Item 31: close remaining quote-count shortfalls, move to Closed Backlog

Closes out CLAUDE.md Active Backlog Item 31 entirely -- all 7 originally
flagged scenarios (2026-08-08 audit) now meet the 5-quote house-rule
minimum:

- "Reactive-only failure hint" (Part VIII): its own section title
  promised coverage of "both Tier A and requirement 9's real-build-
  failure paths" but only ever quoted requirement 9's. Added the
  distinct Tier A (:try_nuitka_tier_a) failure messages from source
  (both call sites, [Extrapolated Branch] since no CI run has hit a
  real Nuitka compiler failure) -- the section now actually covers
  what its title claims. 5 quotes total (was 2).

- Scenario 26 (Conda base periodic update): added the "last update <
  30 days ago" skip branch -- a real, deterministic literal string
  from source, not previously documented at all, and in practice more
  common than the "first install" skip already shown (it's what fires
  on every ordinary repeat bootstrap within the 30-day window) -- plus
  the update-failure line, previously only described in prose. 5
  quotes total (was 3).

- Scenario 41 (Interactive verification): added the PID-display line
  and the live-teed program's own real stdout (hello-from-stub),
  cross-cited from an earlier real capture in the same doc (run
  30328748330, job 90179708091) that already confirmed both as
  genuine console output belonging to this exact live-tee mechanism.
  5 quotes total (was 3).

Item 31 is now fully resolved -- moved from CLAUDE.md's Active Backlog
to docs/agent-closed-backlog.md's Closed Active Backlog Items section
(keeping its original number), consolidating the full three-PR
resolution history (#423/#424/#425) in one place.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW

* docs: cover both reactive-hint failure conditions in opening sentence

CodeRabbit review: the "Reactive-only failure hint" section documented
two genuine triggers (a real Nuitka compiler failure, and Nuitka
reporting success without producing dist\<env>.exe) but its opening
sentence described only the first. Widened the sentence to cover both
while still excluding the forcefail/HP_TEST_FORCE_NUITKA_FAIL test hooks.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A4iE1BRSkUETwz237XeuTW

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants