Fix CRLF distribution for .bat files; add DLL-specific caveat hint

[mixmansoundude]

Summary

Two independent changes, both closing items from docs/open-questions.md:

1. CRLF distribution fix (former open question 2)

Root cause, confirmed live before this fix: raw.githubusercontent.com/.../run_setup.bat served pure LF (0 CRLF pairs, 5,626 bare LF) even though .gitattributes had *.bat text eol=crlf. Git's text=auto normalizes the stored blob to LF on every commit regardless of any eol= override -- eol= only affects what a real git checkout writes to a working tree, a step raw/blob serving never performs. This is exactly what docs/agent-closed-backlog.md's Item 44 (the runtime line-ending self-check) was mitigating, not fixing.

Fix (combining the open question's own options B + C, per maintainer decision that a real enforcement plan closes option B's stated risk):

• .gitattributes: *.bat/*.cmd changed to -text (git performs no line-ending conversion at all, in either direction) -- stored blob, working-tree bytes, and raw-served bytes are now always identical.
• New tools/check_crlf.py (check + --fix) replaces git's own normalization as the enforcement mechanism -- wired into tools/run_sanity_sweep.sh and a new, independent, gating CI job (crlf-check, no needs:, runs immediately). Per this repo's own "gating is a branch-protection setting, not a YAML edit" rule, someone with admin access still needs to add its check name to required-status-checks for it to actually block merges.
• Renormalized the three tracked .bat files (git add --renormalize) -- a one-time, mechanical full-file diff with no real content change (the working-tree bytes were already genuine CRLF via the old checkout-time conversion; only the stored blob was wrong).
• Contributor-facing warning banner on all three .bat files: do not edit via the GitHub web editor or a Mac/Linux tool.
• GitHub Pages (publish_diag job) now also republishes a guaranteed-CRLF run_setup.bat on every push to main -- a second, independent distribution point decoupled entirely from git blob/raw-URL semantics, as a fallback if the raw link ever misbehaves.
• README: new top-of-file "Just want the file?" pointer, and a revised TL;DR bullet now that raw downloads are expected to work.
• Optional tools/githooks/pre-commit + CONTRIBUTING.md note (CI is the real gate; this just saves a round-trip).
• No CI auto-fix-and-commit anywhere -- matches this repo's existing "only inline_model_fix.py may commit auto-fixes" rule.

2. DLL-specific postflight caveat hint (former open question 1, answered yes)

The post-flight caveat panel now surfaces a real, already-computed fact from :dll_bundle_recover (the native-DLL bundling repair loop) instead of staying purely generic. New HP_DLL_HINT_STATE variable (captured before the NDJSON gate, reset once per fresh build attempt) and :pfb_dll_hint subroutine dispatch into 3 wording buckets -- a prior review finding established detection and repair are not the same event, so the wording must not claim more than each state means (skipped / attempted-and-failed / repaired).

Both open questions are now resolved and folded into docs/agent-closed-backlog.md; docs/open-questions.md is back to empty.

Test plan

• python tools/check_delimiters.py run_setup.bat run_tests.bat tests/dynamic_tests.bat -- clean
• python tools/check_crlf.py -- all 3 tracked .bat files pure CRLF
• Verified the staged git blobs are pure CRLF post-renormalize (not just the working tree)
• python -m compileall -q . / python -m pyflakes . -- clean
• python -m yamllint .github/workflows/ / actionlint -oneline .github/workflows/*.yml -- clean
• PowerShell AST parse sweep (tests/*.ps1, tools/*.ps1) -- clean
• python -m pytest tests/test_*.py -q -- 528 passed, 3 skipped (includes 13 new tests for tools/check_crlf.py)
• New tests/harness.ps1 static check (batch.dll_bundle.caveat_hint) verified directly against the real run_setup.bat content via a standalone pwsh run of the same regex logic before landing, not just reasoned about
• ASCII sweep -- clean
• Diffed LF-normalized old vs. new run_setup.bat to confirm the renormalization commit introduced only the intended banner + DLL-hint changes, nothing else
• Full Windows CI matrix (real/conda-full gating lanes) -- pending this PR's own CI run

🤖 Generated with Claude Code

https://claude.ai/code/session_017SQ1rvJxDbE71pTXJ4QvLV

---

Generated by Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 246d6115-5080-40a5-bdfb-cb063575aed6

📥 Commits

Reviewing files that changed from the base of the PR and between 6ba02b0 and c35c08b.

📒 Files selected for processing (19)

• .gitattributes
• .github/workflows/batch-check.yml
• .gitignore
• CLAUDE.md
• CONTRIBUTING.md
• README.md
• docs/agent-closed-backlog.md
• docs/agent-interconnect.md
• docs/agent-lessons-learned.md
• docs/agent-ndjson.md
• docs/open-questions.md
• run_setup.bat
• run_tests.bat
• tests/dynamic_tests.bat
• tests/harness.ps1
• tests/test_check_crlf.py
• tools/check_crlf.py
• tools/githooks/pre-commit
• tools/run_sanity_sweep.sh

---

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Added reliable CRLF preservation and validation for Windows batch files.
  • Added download guidance, including a GitHub Pages mirror for the setup script.
  • Added clearer post-build messages for DLL repair outcomes.

• Bug Fixes

  • Improved handling and display of unresolved or partially repaired DLL issues.

• Documentation

  • Updated setup, contribution, and troubleshooting guidance for line endings and downloads.

• Tests

  • Added automated coverage for CRLF validation, repair, and DLL status messaging.

Walkthrough

The change preserves CRLF bytes for .bat and .cmd files, adds checker and fixer tooling with tests, integrates validation into CI and hooks, documents download handling, and adds DLL post-flight hint regression coverage.

Changes

Batch-file CRLF enforcement

Layer / File(s)	Summary
CRLF policy and contributor guidance .gitattributes, .gitignore, CONTRIBUTING.md, run_tests.bat, tests/dynamic_tests.bat	Batch and command files use -text. Contributor instructions define CRLF-preserving editing and repair.
Checker, fixer, and unit coverage tools/check_crlf.py, tests/test_check_crlf.py	The utility detects, reports, normalizes, and verifies CRLF endings. Unit and CLI tests cover these behaviors.
CI, sanity sweep, and pre-commit validation .github/workflows/batch-check.yml, tools/run_sanity_sweep.sh, tools/githooks/pre-commit	CI, the sanity sweep, and the optional hook validate tracked or staged batch files. Pages publishing validates run_setup.bat before copying it.
Distribution and repository documentation README.md, CLAUDE.md, docs/agent-closed-backlog.md, docs/agent-lessons-learned.md, docs/open-questions.md	Documentation describes byte-preserving downloads, CRLF checks, repair commands, Pages distribution, and resolved line-ending decisions.

DLL post-flight hint coverage

Layer / File(s)	Summary
DLL outcome propagation and regression coverage docs/agent-interconnect.md, tests/harness.ps1, docs/agent-ndjson.md, docs/agent-closed-backlog.md	DLL hint state reset, capture timing, post-flight dispatch, outcome wording, and static registry coverage are documented and checked.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• mixmansoundude/Python_vs_Windows#416: Directly relates to DLL recovery outcome handling used by the post-flight hint changes.
• mixmansoundude/Python_vs_Windows#433: Directly relates to batch-file line-ending handling and validation.
• mixmansoundude/Python_vs_Windows#434: Directly relates to run_setup.bat line-ending handling.

Suggested reviewers: claude

Sequence Diagram(s)

sequenceDiagram
  participant Git
  participant Checker as tools/check_crlf.py
  participant CI as crlf-check
  participant Pages as GitHub Pages
  Git->>Checker: Discover tracked .bat and .cmd files
  Checker->>CI: Return CRLF validation status
  CI->>Pages: Validate and copy run_setup.bat

Loading

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/batch-crlf-strategy-pdi9h5

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}