fix: conformance tests for tools_call and auth/scope-step-up#1022
Merged
Conversation
github-actions
Bot
added
T-CI
alexhancock
commented
Jul 21, 2026
| .ok() | ||
| .and_then(|version| serde_json::from_value(Value::String(version)).ok()) | ||
| .unwrap_or(ProtocolVersion::V_2026_07_28) | ||
| .unwrap_or(ProtocolVersion::V_2025_11_25) |
Contributor
Author
There was a problem hiding this comment.
The node module defaults to this in its code for this ENV var
It is set to the new version when the command is run with --spec-version 2026-07-28 so we still have coverage of the new way
DaleSeo
previously approved these changes
Jul 21, 2026
Member
There was a problem hiding this comment.
How about we delete this file and remove the following lines?
rust-sdk/.github/workflows/conformance.yml
Line 168 in 8803d39
|
|
||
| fn uses_discover_lifecycle() -> bool { | ||
| conformance_protocol_version().as_str() >= ProtocolVersion::V_2026_07_28.as_str() | ||
| } |
Member
There was a problem hiding this comment.
nit: I guess this isn't really worth having its own function?
Contributor
Author
There was a problem hiding this comment.
Good call - done
alexhancock
force-pushed
the
alexhancock/issue-1002
branch
from
July 22, 2026 16:43
99057ba to
3b8bdcc
Compare
Contributor
Author
|
@DaleSeo All feedback addressed |
jamadeo
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools_callandauth/scope-step-upconformance testsexpected-failures-2026-07-28.yaml