fix: reap completed response send tasks#1026
Merged
DaleSeo merged 1 commit intoJul 23, 2026
Merged
Conversation
15 tasks
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
response_send_taskscurrently retains every completed task until transport shutdown. A long-lived stdio server therefore grows resident memory with each request even though the response write has completed.In a sequential 5,000-call stdio soak, one downstream server grew from 42.9 MiB RSS after warm-up to 60.3 MiB. Direct calls to its handler stayed flat, isolating the growth to the SDK serve loop. With this change, the same stdio workload stayed between 46.1 and 47.3 MiB.
Verification
cargo +1.97.0 fmt --all -- --checkcargo +1.97.0 check -p rmcp --features server,transport-iocargo +1.97.0 test -p rmcp --features server,transport-io --test test_stdio_response_concurrency