fix(core-internal): release the ReadBuffer backing allocation after the last message - #2811
Draft
nikolas-sapa wants to merge 1 commit into
Draft
nikolas-sapa wants to merge 1 commit into
nikolas-sapa wants to merge 1 commit into
Conversation
…ast message readMessage() advanced the buffer with subarray(index + 1). When the newline was the final byte, that returned an empty view which still referenced the backing allocation of the consumed input — keeping it alive until the next append, and forcing that append through Buffer.concat even though no bytes were buffered. Drop the buffer entirely when the remainder is empty: append() and clear() already handle _buffer === undefined. Fixes modelcontextprotocol#2536
🦋 Changeset detectedLatest commit: e16a162 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2536.
ReadBuffer.readMessage()advanced the buffer withthis._buffer.subarray(index + 1). When the newline was the final byte of the chunk, that returns a zero-length view that still references the backing allocation of the consumed input. The bytes stay reachable until the nextappend()replaces the view, and thatappend()is forced throughBuffer.concateven though nothing is actually buffered.Dropping the buffer when the remainder is empty releases the allocation immediately.
append()andclear()already handle_buffer === undefined, so no other call site changes.Opened as a draft to respect the one-open-PR limit for contributors without write access — I'll mark it ready once #2807 and #2809 clear.