Skip to content

Fix timeout reset upon progress notification - #2817

Open
lowlyocean wants to merge 1 commit into
modelcontextprotocol:mainfrom
lowlyocean:fix_progress_notification_timer_reset
Open

Fix timeout reset upon progress notification#2817
lowlyocean wants to merge 1 commit into
modelcontextprotocol:mainfrom
lowlyocean:fix_progress_notification_timer_reset

Conversation

@lowlyocean

@lowlyocean lowlyocean commented Sep 14, 2026

Copy link
Copy Markdown

Motivation and Context

Closes #2816

How Has This Been Tested?

Ran the full test suite

Breaking Changes

No breaking changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

This fixes MCP inspector v2, which claims to automatically reset request timeout when progress notifications are received

@lowlyocean
lowlyocean requested a review from a team as a code owner September 14, 2026 12:27
@changeset-bot

changeset-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8e1043a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2817

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2817

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2817

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2817

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2817

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2817

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2817

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2817

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2817

commit: 8e1043a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2] _resetTimeout never updates startTime, so totalElapsed keeps accumulating from the original

1 participant