chore(changesets): only bump peer dependents when out of range - #2819
Open
claude[bot] wants to merge 1 commit into
Open
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012VRbFCp41otcScXE1YY3es
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Felix Weinberger · Slack thread
Problem: with the currently pending changesets,
changeset versionbumps@modelcontextprotocol/node,@modelcontextprotocol/express,@modelcontextprotocol/honoand@modelcontextprotocol/fastifyfrom 2.0.0 to 3.0.0 (see #2808). The DPoP changeset isminoronclient+core, which sit in afixedgroup withserver, soservergoes to 2.1.0; changesets by default treats every peer dependent of a bumped package as needing a major, even though the adapters'workspace:^peer range still covers 2.1.0.Fix: set
onlyUpdatePeerDependentsWhenOutOfRange: trueunder___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCHin.changeset/config.json(as a top-level key changesets silently ignores it). Peer dependents then only bump when the new version leaves their declared peer range;workspace:^stays in range for minors and patches, so the adapters take their own patch bump fromrequest-body-size-limit.mdinstead of a spurious major.Dry runs of
pnpm exec changeset versionagainst mainb65426158(11 pending changesets):@modelcontextprotocol/core@modelcontextprotocol/client@modelcontextprotocol/server@modelcontextprotocol/server-legacy@modelcontextprotocol/codemod@modelcontextprotocol/core-internal@modelcontextprotocol/node@modelcontextprotocol/express@modelcontextprotocol/hono@modelcontextprotocol/fastifypnpm packof the versionednode,expressandhonopackages publishes their@modelcontextprotocol/serverpeer range as^2.1.0, which is the existingworkspace:^behaviour and is unaffected by this option.VERSIONING.mdalready documents that the adapters bump only when their@modelcontextprotocol/serverpeer range has to move (or for their own changes), so no doc change; no changeset because this is config-only.🤖 Generated with Claude Code
https://claude.ai/code/session_012VRbFCp41otcScXE1YY3es