You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With StreamableHTTP, a POST can get a text/event-stream body that hits EOF or errors before the matching JSON-RPC response arrives. The transport already notices this and fires onRequestStreamEnd, but Protocol.request never passed that callback into transport.send, so the pending request just sat there until the outer timeout.
This threads the callback through: the caller's onRequestStreamEnd still runs, and the request now rejects promptly with ConnectionClosed instead of waiting for a timeout. Verified with tsc --noEmit clean and the 49 protocol tests passing.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With StreamableHTTP, a POST can get a text/event-stream body that hits EOF or errors before the matching JSON-RPC response arrives. The transport already notices this and fires onRequestStreamEnd, but Protocol.request never passed that callback into transport.send, so the pending request just sat there until the outer timeout.
This threads the callback through: the caller's onRequestStreamEnd still runs, and the request now rejects promptly with ConnectionClosed instead of waiting for a timeout. Verified with tsc --noEmit clean and the 49 protocol tests passing.