PYTHON-6081 test_list_collections in test_typing.py fails when the test database is empty - #3056
Merged
Merged
Conversation
…st database is empty
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The test now handles empty databases and cleans up after itself.
Pull request overview
Fixes test_list_collections when the test database is empty.
Changes:
- Creates a temporary collection before listing.
- Cleans up the collection afterward.
File summaries
| File | Description |
|---|---|
test/test_typing.py |
Makes the collection-listing test reliable and isolated. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…st database is empty
PYTHON-6081
Changes in this PR
add collection prior to calling list collection to ensure that there is always at least one collection :)
Test Plan
typing tests pass when run in the same situation that caused it to fail before :)
Checklist
Checklist for Author
Checklist for Reviewer