Retry Lando requests - #298
Merged
Merged
Conversation
This will help fix mozilla/code-review#3537.
There was a problem hiding this comment.
Pull request overview
This PR introduces a shared, retry-enabled requests.Session helper and migrates Lando/Phabricator HTTP calls to use it, aiming to improve reliability of Lando requests (per the linked issue).
Changes:
- Add
utils.get_session()that returns a cachedrequests.Sessionconfigured withurllib3.Retryand a larger connection pool. - Switch
libmozdata/lando.pyandlibmozdata/phabricator.pyHTTP calls from directrequests.*usage toget_session(...).*. - Add an explicit
urllib3dependency inrequirements.txtto support directRetryusage.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| requirements.txt | Adds urllib3 as an explicit dependency for retry support. |
| libmozdata/utils.py | Introduces cached, retry-configured requests.Session factory. |
| libmozdata/phabricator.py | Uses shared retry-enabled session for Conduit POST requests (and removes prior bespoke retry loop). |
| libmozdata/lando.py | Uses shared retry-enabled session for Lando GET/POST/DELETE calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
suhaibmujahid
approved these changes
Aug 4, 2026
suhaibmujahid
left a comment
suhaibmujahid
left a comment
Member
There was a problem hiding this comment.
LGTM! The test failure seems unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help fix mozilla/code-review#3537.