Skip to content

fix: Add custom vnet support for windows node. - #154

Merged
rjaini merged 2 commits into
masterfrom
changes
Oct 30, 2019
Merged

fix: Add custom vnet support for windows node.#154
rjaini merged 2 commits into
masterfrom
changes

Conversation

@rjaini

@rjaini rjaini commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

Add custom vnet support for windows node.

MASTER_VNET_ID="/subscriptions/$TENANT_SUBSCRIPTION_ID/resourceGroups/$RESOURCE_GROUP_NAME/providers/Microsoft.Network/virtualNetworks/$CUSTOM_VNET_NAME/subnets/$MASTER_SUBNET_NAME"
AGENT_VNET_ID="/subscriptions/$TENANT_SUBSCRIPTION_ID/resourceGroups/$RESOURCE_GROUP_NAME/providers/Microsoft.Network/virtualNetworks/$CUSTOM_VNET_NAME/subnets/$AGENT_SUBNET_NAME"

cat $AZURESTACK_CONFIGURATION | \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have only windows nodes in the cluster? If yes, we need to add the condition "if [ "$LINUX_AGENT_COUNT" != "0" ]" condition

@rjaini rjaini Oct 30, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. Let me handle that situation as well.

@rjaini
rjaini merged commit e5efb33 into master Oct 30, 2019
@rjaini
rjaini deleted the changes branch October 30, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants